Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: Add option dialogue error handling needs to be modified #14126

Closed
Piyush3079 opened this Issue Mar 27, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Piyush3079
Copy link
Contributor

Piyush3079 commented Mar 27, 2018

Steps to reproduce

  1. In the designer, click on the gear icon to the right pf any column.
  2. A dialogue box will appear to add options to the column.
  3. Fill the Relationship operator and let the value sub query field be empty and click OK.

Expected behaviour

A proper error should be highlighted with the error text message.

Actual behaviour

A small green box appears on the top left corner with error.

screenshot from 2018-03-27 13-32-18

Client configuration

Browser:
Google-Chrome
Operating system:
Ubuntu 17.10

@Piyush3079

This comment has been minimized.

Copy link
Contributor Author

Piyush3079 commented Mar 27, 2018

I have already started working on this issue

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Mar 29, 2018

Designer: Add option dialogue error handling needs to be modified php…
…myadmin#14126

Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

mauriciofauth added a commit that referenced this issue Mar 30, 2018

Designer: "Add options" dialog doesn't reset when canceling: #14110 i…
…ssue fixed (#14117)

* Designer: "Add options" dialog doesn't reset when canceling: Fix #14110
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

* Designer: Add option dialogue error handling needs to be modified Fix #14126
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
(cherry picked from commit 6700b2d)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.