Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not showing previous query on clearing Codemirror and then clicking get saved query #14148

Closed
Piyush3079 opened this issue Apr 1, 2018 · 0 comments · Fixed by #14166
Closed

Not showing previous query on clearing Codemirror and then clicking get saved query #14148

Piyush3079 opened this issue Apr 1, 2018 · 0 comments · Fixed by #14166
Assignees
@MauricioFauth
Labels
Bug A problem or regression with an existing feature
Milestone
5.0.0

Comments

@Piyush3079
Copy link
Contributor

Piyush3079 commented Apr 1, 2018 •
edited

Steps to reproduce

  1. In the current master clear the browser data of PMA and then logout.
  2. Now Login again.
  3. Go to sql tab of table, it will show select * from <table-name> where 1;
  4. Now clear the code-mirror text and refresh again.
  5. Click get auto saved query.

Expected behaviour

As we have cleared the code-mirror query and clicked get auto saved query, it will show previous saved query.

Actual behaviour

It is showing empty code-mirror while the hidden text-area is still showing the default query which either has to be with code-mirror too or will show previous query.

Client configuration

Browser:
Google Chrome

Operating system:
Linux 17.10
@Piyush3079 Piyush3079 changed the title Showing default query on clearing Codemirror Not showing either default or previous query on clearing Codemirror Apr 1, 2018
@Piyush3079 Piyush3079 mentioned this issue Apr 1, 2018
Closed
@Piyush3079 Piyush3079 changed the title Not showing either default or previous query on clearing Codemirror Not showing previous query on clearing Codemirror and then clicking get saved query Apr 4, 2018
Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Apr 4, 2018
@Piyush3079
Not showing previous query on clearing Codemirror and then clicking g…
7054fbc 
…et saved query: phpmyadmin#14148 issue solved

currently typed query stored in temp variable in localstorege which will make get auto save query button functional
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079 Piyush3079 mentioned this issue Apr 6, 2018
Merged
4 tasks
@MauricioFauth MauricioFauth self-assigned this May 3, 2018
@MauricioFauth MauricioFauth added the Bug A problem or regression with an existing feature label May 3, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone May 3, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
Bug A problem or regression with an existing feature
Projects
None yet
Milestone
5.0.0
2 participants
@MauricioFauth @Piyush3079