/phpmyadmin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing previous query on clearing Codemirror and then clicking get saved query #14148

Closed
Piyush3079 opened this Issue Apr 1, 2018 · 0 comments

Comments

Assignees

@mauriciofauth mauriciofauth

Labels
bug
Projects
None yet
Milestone
  5.0.0
2 participants
@Piyush3079 @mauriciofauth
@Piyush3079
Contributor

Piyush3079 commented Apr 1, 2018 •
edited

Steps to reproduce

  1. In the current master clear the browser data of PMA and then logout.
  2. Now Login again.
  3. Go to sql tab of table, it will show select * from <table-name> where 1;
  4. Now clear the code-mirror text and refresh again.
  5. Click get auto saved query.

Expected behaviour

As we have cleared the code-mirror query and clicked get auto saved query, it will show previous saved query.

Actual behaviour

It is showing empty code-mirror while the hidden text-area is still showing the default query which either has to be with code-mirror too or will show previous query.

Client configuration

Browser:
Google Chrome

Operating system:
Linux 17.10

@Piyush3079 Piyush3079 changed the title from Showing default query on clearing Codemirror to Not showing either default or previous query on clearing Codemirror Apr 1, 2018

@Piyush3079 Piyush3079 referenced this issue Apr 1, 2018

Closed

"Show this query here again" checkbox does not work #14144

@Piyush3079 Piyush3079 changed the title from Not showing either default or previous query on clearing Codemirror to Not showing previous query on clearing Codemirror and then clicking get saved query Apr 4, 2018

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Apr 4, 2018

@Piyush3079
Not showing previous query on clearing Codemirror and then clicking g… 
…et saved query: phpmyadmin#14148 issue solved

currently typed query stored in temp variable in localstorege which will make get auto save query button functional
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
7054fbc

@Piyush3079 Piyush3079 referenced this issue Apr 6, 2018

Merged

Changes to make Get auto saved query and show this query here again button functional #14166

4 of 4 tasks complete

@mauriciofauth mauriciofauth closed this in #14166 May 3, 2018

@mauriciofauth mauriciofauth self-assigned this May 3, 2018

@mauriciofauth mauriciofauth added the bug label May 3, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment