Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Move columns preview SQL #14155

Closed
ChrisHSandN opened this Issue Apr 3, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@ChrisHSandN
Copy link

ChrisHSandN commented Apr 3, 2018

Steps to reproduce

  1. On any table
  2. Structure Tab
  3. Move Columns

Expected behaviour

Move Columns modal should have a "Preview SQL" button which shows the SQL which will be run.

This would make is consistent with the structure change, relationship view, edit index, insert etc. which all have a Preview SQL option.

Actual behaviour

Only "OK" and "Cancel" is available.

@Piyush3079

This comment has been minimized.

Copy link
Contributor

Piyush3079 commented Apr 21, 2018

I also think that this feature should be implemented in the coming releases as PMA is also a source for learning sql queries to be used for various functions for beginners. Therefore there should be as much preview sql options as possible so that user can see what query is exactly being generated by using a particular function of PMA so that he can learn as many sql queries as possible.
PMA helped me too in learning many sql queries by using preview sql feature @mauriciofauth @ibennetch .
Although I have started working on this.

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Apr 21, 2018

Move columns preview SQL: phpmyadmin#14155 feature added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Apr 21, 2018

Move columns preview SQL: phpmyadmin#14155 feature added
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018

@mauriciofauth mauriciofauth self-assigned this May 4, 2018

mauriciofauth added a commit that referenced this issue May 4, 2018

Add ChangeLog entries for #12373 and #14155
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.