Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme problem in 4.8 version #14175

Closed
wcizmowski opened this issue Apr 10, 2018 · 7 comments
Closed

Theme problem in 4.8 version #14175

wcizmowski opened this issue Apr 10, 2018 · 7 comments
Assignees

Comments

@wcizmowski
Copy link

@wcizmowski wcizmowski commented Apr 10, 2018

Steps to reproduce

  1. clone phpMyAdmin
  2. copy metro theme into thees folder
  3. theme do not work....

Expected behaviour

Tell us what should happen
Metro style should be visible

Actual behaviour

Tell us what happens instead
Nothing happend after change into metro style

Server configuration

Operating system:
Linux Mint (latest with updates)

Web server:
nginx from docker

Database:
MariaDB 10.1

PHP version:
7.1

phpMyAdmin version:
4.8

Client configuration

Browser:
Chrome latest

Operating system:
Linux Mint

@aroralakshya
Copy link
Contributor

@aroralakshya aroralakshya commented Apr 10, 2018

The supports parameter in the theme.json file says '4.7', changing it to 4.9 shows the theme in the themes options, but the theme doesn't work, I think you should wait for a new release of this theme.
EDIT
This theme works well when I'm testing on current 4.7 STABLE.

@wcizmowski
Copy link
Author

@wcizmowski wcizmowski commented Apr 10, 2018

Hi, after change into '4.8' inside theme.json, thsi theme is in select list, but is totaly incompatible, because on the screen I have incorrect result....
Over 4.7 works, right.
So, we have to wait for next Release for this theme /metro/ ?

@ayurmedia
Copy link

@ayurmedia ayurmedia commented Apr 16, 2018

themes are broken "metro 4.7" is impossible to use. even if you create theme.json 100 broken links. how about migrating and upgrading themes and make in compatible. instead of just breaking the api ?

@ibennetch ibennetch mentioned this issue Apr 19, 2018
4 of 4 tasks complete
@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Apr 19, 2018

The Metro theme is now working on the demo. We just need to make it available for download on the website.

@ibennetch
Copy link
Member

@ibennetch ibennetch commented Apr 19, 2018

There are a lot of layers to this report.

First, you've called my attention to the fact that our web page at https://www.phpmyadmin.net/themes/ doesn't list any 4.8 themes, even though metro is compatible with version 4.8.

Editing the theme.json file won't accomplish much because the rest of the theme still isn't updated.

@wcizmowski From where did you get the metro theme? You can download it from the theme repository at https://github.com/phpmyadmin/themes which will give you a version compatible with 4.8. We'll continue to investigate why metro isn't showing at phpmyadmin.net as compatible with 4.8, if I had to guess I'd say it's probably a version tag issue.

Themes are generally submitted and maintained by third party contributors so they're often not updated quickly after a release (or ever, in many cases). Pull requests against the theme repository are welcome. The themes that are officially maintained and distributed as part of the phpMyAdmin download are kept up to date with the current version.

@ibennetch
Copy link
Member

@ibennetch ibennetch commented Apr 19, 2018

I've just published Maurício's work on Metro at https://www.phpmyadmin.net/themes/#pma_4_8

@ibennetch ibennetch closed this Apr 19, 2018
@joho1968
Copy link

@joho1968 joho1968 commented May 8, 2018

I just upgraded a phpMyAdmin instance to 4.8.0.1 and the metro theme to the one in the above link, still not working. I previously had Metro theme working nicely with phpMyAdmin. This is a completely fresh phpMyAdmin installation, I only moved the config from the previous installation. Even if I enable the Theme Manager and select Metro, nothing happens. I'm sure it's my fault somehow, but just in case I did it right, I'm reporting it here.

EDIT

Now working. I removed the $cfg['ThemeDefault'] option, reloaded phpMyAdmin, and it was working again. Not sure why. I've never seen PHP behave like this before. But either way, sorry about the bogus report.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.