Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Theme problem in 4.8 version #14175
Steps to reproduce
Tell us what should happen
Tell us what happens instead
The supports parameter in the theme.json file says '4.7', changing it to 4.9 shows the theme in the themes options, but the theme doesn't work, I think you should wait for a new release of this theme.
There are a lot of layers to this report.
First, you've called my attention to the fact that our web page at https://www.phpmyadmin.net/themes/ doesn't list any 4.8 themes, even though metro is compatible with version 4.8.
Editing the theme.json file won't accomplish much because the rest of the theme still isn't updated.
@wcizmowski From where did you get the metro theme? You can download it from the theme repository at https://github.com/phpmyadmin/themes which will give you a version compatible with 4.8. We'll continue to investigate why metro isn't showing at phpmyadmin.net as compatible with 4.8, if I had to guess I'd say it's probably a version tag issue.
Themes are generally submitted and maintained by third party contributors so they're often not updated quickly after a release (or ever, in many cases). Pull requests against the theme repository are welcome. The themes that are officially maintained and distributed as part of the phpMyAdmin download are kept up to date with the current version.
I just upgraded a phpMyAdmin instance to 188.8.131.52 and the metro theme to the one in the above link, still not working. I previously had Metro theme working nicely with phpMyAdmin. This is a completely fresh phpMyAdmin installation, I only moved the config from the previous installation. Even if I enable the Theme Manager and select Metro, nothing happens. I'm sure it's my fault somehow, but just in case I did it right, I'm reporting it here.
Now working. I removed the $cfg['ThemeDefault'] option, reloaded phpMyAdmin, and it was working again. Not sure why. I've never seen PHP behave like this before. But either way, sorry about the bogus report.