New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember table's sorting broken in 4.8.0 #14189

Closed
Xymph opened this Issue Apr 12, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@Xymph

Xymph commented Apr 12, 2018

Steps to reproduce

  1. Go to: Settings -> Main panel -> Browse mode
  2. Remove checkmark at Remember table's sorting, Apply
  3. Log out, log in, repeat step 1; observe the checkmark is still there
  4. Browse to database table with a Date column sorted ASC
  5. Change sorting to DESC
  6. Log out, log in, repeat step 4; observe the table is again sorted ASC

Expected behaviour

The status of "Remember table's sorting" should be stored and displayed correctly.

The table's sorting to DESC should be preserved.

This worked fine prior to the 4.8.0 update.

Actual behaviour

The "Remember table's sorting" status in the settings is always shown checked.

The table's sorting is not remembered, despite the checkmark above.

Server configuration

Operating system: Scientific Linux 6.9

Web server: Apache 2.2.15

Database: MySQL 5.5.59

PHP version: 5.6.35

phpMyAdmin version: 4.8.0

Client configuration

Browser: Firefox ESR 52.7.3

Operating system: Scientific Linux 6.9

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 12, 2018

On having a quick look, I couldn't find any code written to handle 'Remember table sorting' configuration.

@Piyush3079

This comment has been minimized.

Contributor

Piyush3079 commented Apr 14, 2018

I have started working on this issue.
For me the status of "Remember table's sorting" is displaying correctly after changing the checkbox and login again.

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 14, 2018

For me too, but it doesn't work, does it??

@Piyush3079

This comment has been minimized.

Contributor

Piyush3079 commented Apr 15, 2018

No, it is not working for me too.

Piyush3079 added a commit to Piyush3079/phpmyadmin that referenced this issue Apr 16, 2018

Remember table's sorting broken in 4.8.0 issue: phpmyadmin#14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

mauriciofauth added a commit that referenced this issue May 12, 2018

Merge pull request #14204 from Piyush3079/PMA_14189
Remember table's sorting broken in 4.8.0 issue: #14189 fixed

mauriciofauth added a commit that referenced this issue May 12, 2018

Remember table's sorting broken in 4.8.0 issue: #14189 fixed
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>

(cherry picked from commit e58dd74)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit that referenced this issue May 12, 2018

Add ChangeLog entry for #14189
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth self-assigned this May 12, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 12, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented May 12, 2018

Closed this in #14204.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment