New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression - Scrolling down messes up the fixed column names #14193

Closed
nunoperalta opened this Issue Apr 13, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@nunoperalta

nunoperalta commented Apr 13, 2018

When scrolling down, besides having two scroll bars now, the fixed column names on the top get "messed up", not aligning properly to the columns shown, and also won't move as I scroll horizontally.

This is on 4.8.0, with the introduction of the extra scrollbars.

image

@ibennetch

This comment has been minimized.

Member

ibennetch commented Apr 13, 2018

It's interesting that you posted this around the same time I was experiencing similar frustration on the page to edit a column structure:

image

I imagine the two are related.

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

Yeah, and creating a new table also has some UI problems.

It doesn't make any sense to release major versions without actually testing them...

image

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

@nulll-pointer nulll-pointer referenced this issue Apr 13, 2018

Closed

Fix for ui regression issues #14196

4 of 4 tasks complete
@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

@nunoperalta, @ibennetch, can you post a bigger screen shot?? The problem isn't exactly visible.

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

sshot-2018-04-13-20-50-02-1

sshot-2018-04-13-20-50-15-1

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

image

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>
@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

I've fixed the issue in first two screenshots.
I don't think there is any issue with the structures page, you'll have to scroll horizontally anyway.

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

I understand, but the only issue (which doesn't affect me anyway) is that the word "Structure" doesn't show completely.

Thank you very much for fixing the issues.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 14, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Apr 25, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone Apr 25, 2018

@BePsvPT BePsvPT referenced this issue Jun 19, 2018

Closed

fix table horizontal scrolling bug #14403

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment