Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Issue - I have to scroll down, to be able to scroll horizontally #14194

Closed
nunoperalta opened this issue Apr 13, 2018 · 11 comments
Closed

UI Issue - I have to scroll down, to be able to scroll horizontally #14194

nunoperalta opened this issue Apr 13, 2018 · 11 comments
Assignees

Comments

@nunoperalta
Copy link

nunoperalta commented Apr 13, 2018

With the introduction of the extra scrollbars, usability is harder when viewing tables.

Besides the related regression issues #14193 and #14169,

now when I want to scroll horizontally, I have to scroll down until I finally find the horizontal scrollbar, move the horizontal scrollbar, then scroll up again, so I can see the data I wanted.

Prior to 4.8.0, I was able to do this by directly using the main body's horizontal scrollbar.

image

@aroralakshya
Copy link
Contributor

Ive started working on this

@aroralakshya
Copy link
Contributor

@ibennetch, should the height of the table be fixed so the table never overflows vertically and horizontal scrollbar is always accessible???

@nunoperalta
Copy link
Author

In my opinion, the way it was before 4.8.0 was perfect and no change was needed...

@aroralakshya
Copy link
Contributor

aroralakshya commented Apr 13, 2018

This change was implemented as the content overflowed in the previous versions.

ui_regression_issue

As shown in the image, the content overflows, horizontal scrollbar was added to prevent this.

@aroralakshya
Copy link
Contributor

I'm adding a scrollbar at the top as well, which will be fixed at the top when you scroll down.
@nunoperalta, what do you think??

@nunoperalta
Copy link
Author

Isn't it better to simply have the table itself overflow (and we control with the main body scrollbars),

and everything else won't pass the 100% width of the body?

The thing is that I don't think it's a good idea to make the table itself in a div with scrolls,

but instead have the table as it was before, but ONLY the table can overflow the body.
Everything else will normally fit to the screen.

@okierie
Copy link

okierie commented Apr 16, 2018

Dear @nulll-pointer, I agree with @nunoperalta. Adding horizontal scrollbar at the top of the table will not make it easier to use. I still have to point the cursor on the scrollbar and drag it. When we in a rush, pointing cursor over a small scrollbar object could be frustrating.
But, if we use the main body scrollbar, we just need to point the cursor at the bottom of the screen, less effort to look for the scrollbar. Also, it would work with keyboard arrows.

@okierie
Copy link

okierie commented Apr 16, 2018

Dear @nunoperalta , my quick fix for this is to override the class of responsivetable using styler addon/extension on the browser. I override overflow-x: auto; to overflow-x: visible;

@nunoperalta
Copy link
Author

Thank you. That is definitely THE solution for this issue ticket.... that's exactly how I want phpMyAdmin to be.

If they come up with some other solution that involves extra scroll bars, I'll just have to patch my phpMyAdmin files to override that style.
(I don't want to use extensions in such critical systems, potentially causing a data breach)

@OlafvdSpek
Copy link

Duplicate of #14029

@MauricioFauth
Copy link
Member

Duplicate of #14029

@MauricioFauth MauricioFauth marked this as a duplicate of #14029 Apr 24, 2018
@MauricioFauth MauricioFauth self-assigned this Apr 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants