New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Issue - I have to scroll down, to be able to scroll horizontally #14194

Closed
nunoperalta opened this Issue Apr 13, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@nunoperalta

nunoperalta commented Apr 13, 2018

With the introduction of the extra scrollbars, usability is harder when viewing tables.

Besides the related regression issues #14193 and #14169,

now when I want to scroll horizontally, I have to scroll down until I finally find the horizontal scrollbar, move the horizontal scrollbar, then scroll up again, so I can see the data I wanted.

Prior to 4.8.0, I was able to do this by directly using the main body's horizontal scrollbar.

image

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

Ive started working on this

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

@ibennetch, should the height of the table be fixed so the table never overflows vertically and horizontal scrollbar is always accessible???

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

In my opinion, the way it was before 4.8.0 was perfect and no change was needed...

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

This change was implemented as the content overflowed in the previous versions.

ui_regression_issue

As shown in the image, the content overflows, horizontal scrollbar was added to prevent this.

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Apr 13, 2018

I'm adding a scrollbar at the top as well, which will be fixed at the top when you scroll down.
@nunoperalta, what do you think??

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>
@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 13, 2018

Isn't it better to simply have the table itself overflow (and we control with the main body scrollbars),

and everything else won't pass the 100% width of the body?

The thing is that I don't think it's a good idea to make the table itself in a div with scrolls,

but instead have the table as it was before, but ONLY the table can overflow the body.
Everything else will normally fit to the screen.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

@nulll-pointer nulll-pointer referenced this issue Apr 13, 2018

Closed

Fix for ui regression issues #14196

4 of 4 tasks complete

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 13, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue Apr 14, 2018

Fix for ui regression issues
Fixes phpmyadmin#14193, phpmyadmin#14194
Implementation:
Add a horizontal scrollbar at the top of the table which is fixed at the top when  the user scrolls down.

Signed-Off-By: Lakshya arora <arora.lakshya123@gmail.com>
@okierie

This comment has been minimized.

okierie commented Apr 16, 2018

Dear @nulll-pointer, I agree with @nunoperalta. Adding horizontal scrollbar at the top of the table will not make it easier to use. I still have to point the cursor on the scrollbar and drag it. When we in a rush, pointing cursor over a small scrollbar object could be frustrating.
But, if we use the main body scrollbar, we just need to point the cursor at the bottom of the screen, less effort to look for the scrollbar. Also, it would work with keyboard arrows.

@okierie

This comment has been minimized.

okierie commented Apr 16, 2018

Dear @nunoperalta , my quick fix for this is to override the class of responsivetable using styler addon/extension on the browser. I override overflow-x: auto; to overflow-x: visible;

@nunoperalta

This comment has been minimized.

nunoperalta commented Apr 16, 2018

Thank you. That is definitely THE solution for this issue ticket.... that's exactly how I want phpMyAdmin to be.

If they come up with some other solution that involves extra scroll bars, I'll just have to patch my phpMyAdmin files to override that style.
(I don't want to use extensions in such critical systems, potentially causing a data breach)

@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented Apr 17, 2018

Duplicate of #14029

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 24, 2018

Duplicate of #14029

@mauriciofauth mauriciofauth marked this as a duplicate of #14029 Apr 24, 2018

@mauriciofauth mauriciofauth self-assigned this Apr 24, 2018

@BePsvPT BePsvPT referenced this issue Jun 19, 2018

Closed

fix table horizontal scrolling bug #14403

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment