New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit/Replace view: missing Go button #14249

Closed
karatedad77 opened this Issue May 2, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@karatedad77

karatedad77 commented May 2, 2018

Steps to reproduce

I linked to a view on the official demo server here so you could see the missing Go button.

https://demo.phpmyadmin.net/master-config/view_create.php?db=alunos&table=alunos_on_v&goto=tbl_structure.php&back=tbl_structure.php&view[operation]=alter&view[definer]=root%40192.168.30.%25&view[sql_security]=DEFINER&view[name]=alunos_on_v&view[as]=select+%60alunos%60.%60alunos_on%60.%60identidade%60+AS+%60identidade%60%2C%60alunos%60.%60alunos_on%60.%60nome%60+AS+%60nome%60+from+%60alunos%60.%60alunos_on%60+where+1&view[with]=NONE&view[algorithm]=UNDEFINED

Creating a view displays the Go button correctly.

Expected behaviour

When editing a view, there should be a "Go" button to execute the view's update.

Actual behaviour

Go button is missing within the Edit view form.

Server configuration

Operating system: N/A

Web server: nginx/1.10.3

Database: MySQL 8.0.3-rc-log

PHP version: 7.2.4-1

phpMyAdmin version: 4.8.x

Client configuration

Browser: Google Chrome 66.0.3359.117 (Official Build) (64-bit)

Operating system: Windows 10

@ppc52776

This comment has been minimized.

ppc52776 commented May 3, 2018

I also have this problem.

@devenbansod devenbansod added the bug label May 5, 2018

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented May 7, 2018

I'm working on this.

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue May 7, 2018

Fix for missing go button in view edit, phpmyadmin#14249
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

nulll-pointer added a commit to nulll-pointer/phpmyadmin that referenced this issue May 7, 2018

Fix for missing go button in view edit, phpmyadmin#14249
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>
@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented May 7, 2018

I have a suggestion.
Currently, there are two GO buttons while creating a view, the second one(beside the cancel button) is redundant and doesn't even work properly. Shouldn't it be removed??

mauriciofauth added a commit that referenced this issue May 9, 2018

Merge pull request #14263 from nulll-pointer/view_alter_error
Fix for missing go button in view edit, #14249

@mauriciofauth mauriciofauth self-assigned this May 9, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 9, 2018

mauriciofauth added a commit that referenced this issue May 9, 2018

Fix for missing go button in view edit, #14249
Signed-Off-By: Lakshay arora <arora.lakshya123@gmail.com>

(cherry picked from commit 3641a65)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit that referenced this issue May 9, 2018

Add ChangeLog entry for #14249
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@ibennetch

This comment has been minimized.

Member

ibennetch commented May 9, 2018

@nulll-pointer Yes, I think we should remove one of the Go buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment