Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DisableIS and database tree list #14252

Closed
askurihin opened this issue May 3, 2018 · 9 comments
Closed

DisableIS and database tree list #14252

askurihin opened this issue May 3, 2018 · 9 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.0.1

Comments

@askurihin
Copy link

askurihin commented May 3, 2018 •
edited by williamdes

Steps to reproduce

  1. set $cfg['Servers'][$i]['DisableIS'] = true; in config.inc.php
  2. open PMA
  3. create new database
  4. refresh PMA

Expected behaviour

New database should appear in the left tree

Actual behaviour

New database only appear after re-login

Server configuration

Operating system:
CentOS 7.4

Web server:
Apache 2.4

Database:
mysql Ver 14.14 Distrib 5.7.19-17, for Linux (x86_64) using 6.2

PHP version:
7.1

phpMyAdmin version:
4.8.0.1

Client configuration

Browser:
Safari/Chrome/Firefox

Operating system:
MacOS/Linux

I tried to debug and found, that when DisableIS is set to false,
it is specially handled, and retrieved every time I refresh the page.
@Viste
Copy link

Viste commented May 4, 2018

confrim

@devenbansod devenbansod added the Bug A problem or regression with an existing feature label May 5, 2018
@williamdes williamdes mentioned this issue Sep 22, 2018
Closed
@KylePinkley
Copy link

This is also affecting cPanel customer's.

These cases in your tracker may be related to this issue:
#10806
#11047

@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes
Copy link
Member

Can someone help me reproduce this issue, I can not reproduce it

@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label May 4, 2019
@williamdes williamdes moved this from To be sorted to Not reproduced in issues May 4, 2019
@KylePinkley
Copy link

@williamdes I have a DigitalOcean VPS with cPanel, Apache 2.4.39, MySQL 5.7, PHP 7.2, custom install of phpMyAdmin 4.8.5 where the issue is happening. Would it help at all if I provided you access to this server so you can see the issue occurring?

@williamdes
Copy link
Member

@KylePinkley Yes, please email me :)

@williamdes williamdes self-assigned this May 13, 2019
@williamdes williamdes removed the question Used when we need feedback from the submitter or when the issue is a question about PMA label May 13, 2019
@williamdes williamdes moved this from Not reproduced to ready to merge in issues May 13, 2019
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 13, 2019
@williamdes
Fix phpmyadmin#14252 - DisableIS and database tree list (refresh db l…
7fe8a1d 
…ist)

Fixes: phpmyadmin#14252
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label May 13, 2019
@williamdes williamdes mentioned this issue May 13, 2019
Merged
@williamdes
Copy link
Member

williamdes commented May 13, 2019 •
edited

@KylePinkley @Viste @askurihin Can you please apply #15269 ( 6464344 ) and approve the changes if the fix works for you

To approve go to the "File changes" tab and use the green dropdown on PR #15269

@KylePinkley
Copy link

KylePinkley commented May 13, 2019 •
edited

@williamdes I did test this on a new VM using phpMyAdmin 4.8.5. I had to add on line 15 in navigation.php:

use PhpMyAdmin\Util;

Then it looks like the changes suggested in 7fe8a1d is working now. Should I approve it even though the line above is missing in the commit?

@williamdes
Copy link
Member

@KylePinkley Thanks for pointing this out, I forgot to add the line
I updated the pull-request :)
The patch is now 6464344

@williamdes williamdes added this to the 4.8.6 milestone May 18, 2019
williamdes added a commit that referenced this issue May 18, 2019
@williamdes
Fix #14252 - DisableIS and database tree list (refresh db list)
8287ab2 
Fixes: #14252
Pull-request: #15269
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 18, 2019
@williamdes
Add ChangeLog entry for #14252
cf55db0 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed May 18, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.0.1
Development

No branches or pull requests
5 participants
@Viste @KylePinkley @devenbansod @williamdes @askurihin