Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git commit info not showing when the repository is a submodule #14253

Closed
williamdes opened this issue May 3, 2018 · 0 comments
Closed

Git commit info not showing when the repository is a submodule #14253

williamdes opened this issue May 3, 2018 · 0 comments
Assignees
@MauricioFauth
Labels
enhancement A feature request for improving phpMyAdmin
Milestone
5.0.0

Comments

@williamdes
Copy link
Member

williamdes commented May 3, 2018 •
edited

Steps to reproduce

  1. mkdir testdir
  2. cd testdir
  3. git init
  4. git submodule add https://github.com/phpmyadmin/phpmyadmin
  5. composer install
  6. Login into phpmyadmin

Expected behaviour

Show git commit info:
selection_028

Actual behaviour

No git commit info:
selection_027

Why

Git uses a file to store the location of .git when the repository is a submodule of the root repository
Execute command (in phpmyadmin folder):
cat .git
the result is :
gitdir: ../.git/modules/phpmyadmin

Documentations:
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 3, 2018
@williamdes
phpmyadmin#14253 Git commit info not showing when the repository is a…
d481058 
… submodule

Added tests for Config::checkGitRevision and Config::isGitRevision

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 3, 2018
@williamdes
phpmyadmin#14253 Git commit info not showing when the repository is a…
9687dfb 
… submodule

Added tests for Config::checkGitRevision and Config::isGitRevision

Closes: phpmyadmin#14253
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue May 3, 2018
Merged
MauricioFauth added a commit that referenced this issue May 4, 2018
@MauricioFauth
Merge pull request #14254 from williamdes/issue-14253-git-submodule
475c186 
#14253 Git commit info not showing when the repository is a submodule
@MauricioFauth MauricioFauth self-assigned this May 4, 2018
@MauricioFauth MauricioFauth added the enhancement A feature request for improving phpMyAdmin label May 4, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone May 4, 2018
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Dec 21, 2018
@williamdes
Added tests for Config::checkGitRevision and Config::isGitRevision
a6b6792 
phpmyadmin#14253
Cherry-Picked-From: 9687dfb
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
enhancement A feature request for improving phpMyAdmin
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@MauricioFauth @williamdes