New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit info not showing when the repository is a submodule #14253

Closed
williamdes opened this Issue May 3, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@williamdes
Member

williamdes commented May 3, 2018

Steps to reproduce

  1. mkdir testdir
  2. cd testdir
  3. git init
  4. git submodule add https://github.com/phpmyadmin/phpmyadmin
  5. composer install
  6. Login into phpmyadmin

Expected behaviour

Show git commit info:
selection_028

Actual behaviour

No git commit info:
selection_027

Why

Git uses a file to store the location of .git when the repository is a submodule of the root repository
Execute command (in phpmyadmin folder):
cat .git
the result is :
gitdir: ../.git/modules/phpmyadmin

Documentations:

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 3, 2018

phpmyadmin#14253 Git commit info not showing when the repository is a…
… submodule

Added tests for Config::checkGitRevision and Config::isGitRevision

Signed-off-by: William Desportes <williamdes@wdes.fr>

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 3, 2018

phpmyadmin#14253 Git commit info not showing when the repository is a…
… submodule

Added tests for Config::checkGitRevision and Config::isGitRevision

Closes: phpmyadmin#14253
Signed-off-by: William Desportes <williamdes@wdes.fr>

mauriciofauth added a commit that referenced this issue May 4, 2018

Merge pull request #14254 from williamdes/issue-14253-git-submodule
#14253 Git commit info not showing when the repository is a submodule

@mauriciofauth mauriciofauth self-assigned this May 4, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment