New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror hints hidden in functions/procedures/triggers #14257

Closed
williamdes opened this Issue May 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@williamdes
Member

williamdes commented May 4, 2018

Steps to reproduce

  1. Install phpmyadmin 4.8.0 / 5.0.0-dev
  2. Create tables
  3. Try to create a function in a database
  4. Start typing SELECT 1 FROM add the first letter of one of your tables and press enter
  5. Hints works but is hidden by the modal

Demo server : https://demo.phpmyadmin.net/QA_4_8/db_routines.php?db=menagerie&server=1

Expected behaviour

See hints

Actual behaviour

Hints are hidden

Solution

.CodeMirror-hints {
    z-index: 999;
}

Screenshots

selection_032
selection_033

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 4, 2018

Patch for phpmyadmin#14257 CodeMirror hints hidden
[CI skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>

mauriciofauth added a commit that referenced this issue May 5, 2018

@mauriciofauth mauriciofauth self-assigned this May 5, 2018

@mauriciofauth mauriciofauth added the bug label May 5, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 5, 2018

mauriciofauth added a commit that referenced this issue May 5, 2018

Patch for #14257 CodeMirror hints hidden
[CI skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit 24f4837)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment