/phpmyadmin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror hints hidden in functions/procedures/triggers #14257

Closed
williamdes opened this Issue May 4, 2018 · 0 comments

Comments

Assignees

@mauriciofauth mauriciofauth

Labels
bug
Projects
None yet
Milestone
  4.8.1
2 participants
@williamdes @mauriciofauth
@williamdes
Member

williamdes commented May 4, 2018

Steps to reproduce

  1. Install phpmyadmin 4.8.0 / 5.0.0-dev
  2. Create tables
  3. Try to create a function in a database
  4. Start typing SELECT 1 FROM add the first letter of one of your tables and press enter
  5. Hints works but is hidden by the modal

Demo server : https://demo.phpmyadmin.net/QA_4_8/db_routines.php?db=menagerie&server=1

Expected behaviour

See hints

Actual behaviour

Hints are hidden

Solution

.CodeMirror-hints {
    z-index: 999;
}

Screenshots

selection_032
selection_033

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 4, 2018

@williamdes
Patch for phpmyadmin#14257 CodeMirror hints hidden 
[CI skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
Verified
This commit was signed with a verified signature.
@williamdes williamdes William Desportes
GPG key ID: 90A0EF1B8251A889 Learn about signing commits
24f4837

@williamdes williamdes referenced this issue May 4, 2018

Merged

Patch for #14257 CodeMirror hints hidden #14258

@mauriciofauth mauriciofauth closed this in #14258 May 5, 2018

mauriciofauth added a commit that referenced this issue May 5, 2018

@mauriciofauth
Merge pull request #14258 from williamdes/issue-14257-codemirror-hints 
Patch for #14257 CodeMirror hints hidden
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2911564

@mauriciofauth mauriciofauth self-assigned this May 5, 2018

@mauriciofauth mauriciofauth added the bug label May 5, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 5, 2018

mauriciofauth added a commit that referenced this issue May 5, 2018

@williamdes @mauriciofauth
Patch for #14257 CodeMirror hints hidden 
[CI skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit 24f4837)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
0d2f70c

@williamdes williamdes referenced this issue May 17, 2018

Closed

Autocomplete feature glitched #14302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment