Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language does not change in 4.8.0.1 #14260

Closed
VARGA-Peter opened this issue May 6, 2018 · 2 comments
Closed

Language does not change in 4.8.0.1 #14260

VARGA-Peter opened this issue May 6, 2018 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@VARGA-Peter
Copy link

@VARGA-Peter VARGA-Peter commented May 6, 2018

Steps to reproduce

Installed 4.8.0.1

Expected behaviour

The language should be as set in $cfg['Lang'] = 'en';

Actual behaviour

All settings according PhpMyAdmin Language Documentation are ignored. My Windows has German localization and PMA uses the German texts.

Server configuration

Operating system:
SLES 12.3

Web server:
Apache 2

Database:
MySQL 5.7.21

PHP version:
7.0.7

phpMyAdmin version:
4.8.0.1

Client configuration

Browser:
IE, Chrome, FF

Operating system:
Windows Server 2012 R2

@williamdes
Copy link
Member

@williamdes williamdes commented May 6, 2018

Confirmed on branch master at revision : bb9fc5d

//not working
$cfg['DefaultLang']
//also not working
$cfg['Lang']

PR sent.
Error : Accessing globals that are not accessible yet, see common.inc.php

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 6, 2018
Closes: phpmyadmin#14260
Signed-off-by: William Desportes <williamdes@wdes.fr>
mauriciofauth added a commit that referenced this issue May 7, 2018
#14260 Fixed configuration for DefaultLang and Lang
@mauriciofauth mauriciofauth self-assigned this May 7, 2018
@mauriciofauth mauriciofauth added the bug label May 7, 2018
@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 7, 2018
mauriciofauth added a commit that referenced this issue May 7, 2018
Closes: #14260
Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit 2f84b40)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
mauriciofauth added a commit that referenced this issue May 7, 2018
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@VARGA-Peter
Copy link
Author

@VARGA-Peter VARGA-Peter commented May 7, 2018

Yep, I implemented it locally on my phpMyAdmin copy and it works!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.