Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language does not change in 4.8.0.1 #14260

Closed
VARGA-Peter opened this issue May 6, 2018 · 2 comments
Closed

Language does not change in 4.8.0.1 #14260

VARGA-Peter opened this issue May 6, 2018 · 2 comments
Assignees
@MauricioFauth
Labels
bug A problem or regression with an existing feature
Milestone
4.8.1

Comments

@VARGA-Peter
Copy link

Steps to reproduce

Installed 4.8.0.1

Expected behaviour

The language should be as set in $cfg['Lang'] = 'en';

Actual behaviour

All settings according PhpMyAdmin Language Documentation are ignored. My Windows has German localization and PMA uses the German texts.

Server configuration

Operating system:
SLES 12.3

Web server:
Apache 2

Database:
MySQL 5.7.21

PHP version:
7.0.7

phpMyAdmin version:
4.8.0.1

Client configuration

Browser:
IE, Chrome, FF

Operating system:
Windows Server 2012 R2
@williamdes
Copy link
Member

williamdes commented May 6, 2018 •
edited

Confirmed on branch master at revision : bb9fc5d

//not working
$cfg['DefaultLang']
//also not working
$cfg['Lang']

PR sent.
Error : Accessing globals that are not accessible yet, see common.inc.php

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 6, 2018
@williamdes
phpmyadmin#14260 Fixed configuration for DefaultLang and Lang
2f84b40 
Closes: phpmyadmin#14260
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue May 6, 2018
Merged
MauricioFauth added a commit that referenced this issue May 7, 2018
@MauricioFauth
Merge pull request #14261 from williamdes/issue-14260-langs-cfg
923157d 
#14260 Fixed configuration for DefaultLang and Lang
@MauricioFauth MauricioFauth self-assigned this May 7, 2018
@MauricioFauth MauricioFauth added the bug A problem or regression with an existing feature label May 7, 2018
@MauricioFauth MauricioFauth added this to the 4.8.1 milestone May 7, 2018
MauricioFauth pushed a commit that referenced this issue May 7, 2018
@williamdes @MauricioFauth
#14260 Fixed configuration for DefaultLang and Lang
8f571f7 
Closes: #14260
Signed-off-by: William Desportes <williamdes@wdes.fr>
(cherry picked from commit 2f84b40)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
MauricioFauth added a commit that referenced this issue May 7, 2018
@MauricioFauth
Add ChangeLog entry for #14260
4ee541a 
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@VARGA-Peter
Copy link
Author

Yep, I implemented it locally on my phpMyAdmin copy and it works!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
bug A problem or regression with an existing feature
Projects
None yet
Milestone
4.8.1
Development

No branches or pull requests
3 participants
@MauricioFauth @williamdes @VARGA-Peter