Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middle-click on foreign key link broken #14270

Closed
OlafvdSpek opened this issue May 9, 2018 · 8 comments
Closed

Middle-click on foreign key link broken #14270

OlafvdSpek opened this issue May 9, 2018 · 8 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature hardening refactoring
Projects
issues
Milestone
4.9.1

Comments

@OlafvdSpek
Copy link

https://demo.phpmyadmin.net/master-config/sql.php?server=1&db=sakila&table=film_actor&pos=0

Middle-clicking on any of the actor_id rows opens a kinda 'blank' page.
@OlafvdSpek
Copy link
Author

Ctrl-clicking doesn't open a new tab like it should.

Normal clicking doesn't update browser history, so the Back button doesn't work properly.

@fliespl
Copy link
Contributor

fliespl commented Aug 28, 2018 •
edited

Confirming it's still this way in 4.8.3. Not possible to open foreign key link via "Open in new tab" or "middle click".

@MauricioFauth MauricioFauth added Bug A problem or regression with an existing feature refactoring hardening labels Aug 28, 2018
@williamdes williamdes mentioned this issue Aug 29, 2018
Closed
@ftrotter ftrotter mentioned this issue Apr 25, 2019
Closed
@Drakar2007 Drakar2007 mentioned this issue Apr 29, 2019
Closed
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes moved this from To be sorted to High priority in issues May 4, 2019
@fliespl
Copy link
Contributor

fliespl commented Jun 11, 2019

Confirming that this bug is still valid for 4.9.0.1.

@williamdes
Copy link
Member

@fliespl Yes..
Needs to be fixed soon

@MauricioFauth
Copy link
Member

This will not be fixed in 5.0 either. This requires a lot of work to be fixed, because we have to change how we handle requests. But we are working on it.

@OlafvdSpek
Copy link
Author

This will not be fixed in 5.0 either.

Why not? IMO it should be a showstopper.

This requires a lot of work to be fixed, because we have to change how we handle requests. But we are working on it.

I'd use GET for simple requests and POST for the more complex ones.

@williamdes
Copy link
Member

williamdes commented Jun 12, 2019 •
edited

You know what, I fixed it !!

Please review #15325

cc @OlafvdSpek @MauricioFauth

@williamdes williamdes mentioned this issue Jun 12, 2019
Merged
@williamdes williamdes moved this from High priority to ready to merge in issues Jun 12, 2019
@williamdes williamdes added this to the 4.9.1 milestone Jun 22, 2019
@williamdes williamdes self-assigned this Jun 22, 2019
williamdes added a commit that referenced this issue Jun 22, 2019
@williamdes
Fix broken foreign key links
d2caddf 
Fixes: #14270 - Middle-click on foreign key link broken
Fixes: #14363 - Broken relational links in tables
Pull-request: #15325

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Jun 22, 2019
williamdes added a commit that referenced this issue Jun 22, 2019
@williamdes
Add ChangeLog entries for #14270 #14363 and #14987
b6a354a 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature hardening refactoring
Projects
issues
  
Closed
Milestone
4.9.1
Development

No branches or pull requests
4 participants
@MauricioFauth @fliespl @OlafvdSpek @williamdes