New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central columns can't be edited or deleted by multiple selection after single edit #14278

Closed
laps15 opened this Issue May 10, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented May 10, 2018

Steps to reproduce

  1. Go to central columns page
  2. Click edit in the action column of the table
  3. Change its name
  4. Click save
  5. Select this column at the checkbox row
  6. Click edit or delete on the 'With selected' section at table bottom

Expected behaviour

If delete was clicked at the last step we expect that the row is deleted from central columns.
If edit was selected, we should be redirected to a page with a form with the row data to be edited.

Actual behaviour

When delete is clicked a warning appears at the top of the page, warining that the '$oldColName' column does not exist in central columns list. And the column is not deleted.

When edit is select I'm redirected to a new page but the form has no fields, because the '$oldColName' does not exist in central columns list.

This happens because when the column name is changed the html attribute "value" of the checkbox row is not updated with the new name.

Server configuration

Operating system:
Ubuntu 18.04

Web server:
Apache/2.4.29 (Ubuntu)

Database:
mysql Ver 14.14 Distrib 5.7.22, for Linux (x86_64) using

PHP version:
PHP 7.2.3-1ubuntu1

phpMyAdmin version:
5.0.0-dev

Client configuration

Browser:
google-chrome

Operating system:
ubuntu 18.04

laps15 added a commit to laps15/phpmyadmin that referenced this issue May 14, 2018

Fix central columns in-line edit bug
fixes phpmyadmin#14278

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@laps15 laps15 referenced this issue May 14, 2018

Merged

Fix central columns in-line edit bug #14286

4 of 4 tasks complete

mauriciofauth added a commit that referenced this issue May 15, 2018

Fix central columns in-line edit bug
fixes #14278

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
(cherry picked from commit dce39bb)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

mauriciofauth added a commit that referenced this issue May 15, 2018

Add ChangeLog entry for #14278
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth self-assigned this May 15, 2018

@mauriciofauth mauriciofauth added the bug label May 15, 2018

@mauriciofauth mauriciofauth added this to the 4.8.1 milestone May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment