Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect linkage from one table's value to another table. #14291

Closed
bs-thomas opened this issue May 15, 2018 · 6 comments
Closed

Incorrect linkage from one table's value to another table. #14291

bs-thomas opened this issue May 15, 2018 · 6 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@bs-thomas
Copy link

bs-thomas commented May 15, 2018

Steps to reproduce

Please see video:
https://cdn.beamstyle.com.hk/phpmyadmin-bug.mp4

Expected behaviour

When clicked, should be able to go to the table with correct query with full value, and not with the "ellipsis" (...) behind it.

Actual behaviour

Goes to the table with wrong query (the query has ellipsis "..." behind it)

(But if you select +Options, and display as "Full Text" then it works)

Server configuration

Web server:
Apache

Database:
5.7

PHP version:
7.0
phpMyAdmin version:
4.7.4

@williamdes
Copy link
Member

Looks like the same issue as #14301

I could not reproduce this issue, @bs-thomas can you help ?

NOTE: TextLink transformation seems to have a bug while saving or updating that adds the html of the transformation.

Demo servers (root, no password)

@williamdes williamdes added question Used when we need feedback from the submitter or when the issue is a question about PMA ui Issues relating to the user interface labels Nov 27, 2018
@williamdes williamdes removed the question Used when we need feedback from the submitter or when the issue is a question about PMA label Mar 31, 2019
@radicand
Copy link

This issue is still present in 4.9.0.1 for what it's worth.

I configured a reproduction on the 5.0.0-dev server in the fk_ellipsis_repro database. Export below in case it gets wiped.

To reproduce:

  • Go to the fk_dep table and browse. Click the link in in the row shown.
  • You should see the row referenced in source on the new page, instead you see no results, and the SQL executed above contains the truncated string in the where clause.

Export:

-- phpMyAdmin SQL Dump
-- version 5.0.0-dev
-- https://www.phpmyadmin.net/
--
-- Host: 192.168.30.23
-- Generation Time: Jun 28, 2019 at 01:44 AM
-- Server version: 8.0.3-rc-log
-- PHP Version: 7.2.18-1+0~20190503103213.21+stretch~1.gbp101320

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET AUTOCOMMIT = 0;
START TRANSACTION;
SET time_zone = "+00:00";


/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8mb4 */;

--
-- Database: `fk_ellipsis_repro`
--

-- --------------------------------------------------------

--
-- Table structure for table `fk_dep`
--

CREATE TABLE `fk_dep` (
  `source_id` varchar(64) COLLATE utf8mb4_unicode_ci NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

--
-- Dumping data for table `fk_dep`
--

INSERT INTO `fk_dep` (`source_id`) VALUES
('01593cc4acf2177c59a6aa934ff7cb3511ea78bf9fb073ba547ecc4941996106');

-- --------------------------------------------------------

--
-- Table structure for table `source`
--

CREATE TABLE `source` (
  `id` varchar(64) COLLATE utf8mb4_unicode_ci NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

--
-- Dumping data for table `source`
--

INSERT INTO `source` (`id`) VALUES
('01593cc4acf2177c59a6aa934ff7cb3511ea78bf9fb073ba547ecc4941996106');

--
-- Indexes for dumped tables
--

--
-- Indexes for table `fk_dep`
--
ALTER TABLE `fk_dep`
  ADD KEY `source_id` (`source_id`);

--
-- Indexes for table `source`
--
ALTER TABLE `source`
  ADD PRIMARY KEY (`id`);

--
-- Constraints for dumped tables
--

--
-- Constraints for table `fk_dep`
--
ALTER TABLE `fk_dep`
  ADD CONSTRAINT `fk_dep_ibfk_1` FOREIGN KEY (`source_id`) REFERENCES `source` (`id`);
COMMIT;

/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;

@williamdes williamdes added the Bug A problem or regression with an existing feature label Jun 28, 2019
@williamdes williamdes added this to Needs triage in issues via automation Jun 28, 2019
@williamdes williamdes moved this from Needs triage to to be fixed soon in issues Jul 10, 2019
@Tithugues
Copy link
Contributor

Hi,
Do we agree that the fix should be provided on the QA_4_9 please?

@williamdes
Copy link
Member

@Tithugues Yes

@Tithugues
Copy link
Contributor

@williamdes , thanks. I'll try to submit a PR on QA_4_9 also.

@Tithugues
Copy link
Contributor

@williamdes , thanks. I'll try to submit a PR on QA_4_9 also.

Just to be clear: it had been done for 4.9 in #15414 and for master in #15411.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 19, 2019
@williamdes williamdes self-assigned this Aug 20, 2019
@williamdes williamdes added this to the 4.9.1 milestone Aug 20, 2019
williamdes added a commit that referenced this issue Aug 20, 2019
Fixes: #14291
Pull-request: #15414

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 20, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 20, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants