JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name #14299

BarthDELUY · 2018-05-16T13:17:19Z

Steps to reproduce

Connect to PMA
After a few minutes, click on a table name on the left sidebar (we are trying to narrow the situation to get the exact steps to reproduce)

Expected behaviour

Default page for this table should open

Actual behaviour

JS Exception "PMA_makegrid is not defined" is thrown. All links stop working, left panel turns white if you click on another table's name or on a top menu link icon. Error occurs on two different servers, with the same software configuration (OS, Apache, PHP, MySQL, PMA versions).
Only solution is to close the tab and reconnect.
This error never occured on Linux or Windows workstations (yet?), only on our 2 developers Mac laptops on Chrome. They started appearing when we switched to phpMyAdmin 4.8.0.0 installed from source the week before version 4.8.0.1 was released, and was not fixed in 4.8.0.1 (I upgraded again the day after 4.8.0.1 was released)
The error did not occur on our previous installation (phpMyAdmin 4.2.12-2+deb8u2 from debian repositories).

Server configuration

Operating system: Debian 8

Web server: Apache 2.4.10

Database: Mysql 5.5.59

PHP version: 5.6.33 via PHP-FPM

phpMyAdmin version: 4.8.0.1

Theme : metro

Client configuration

Browser: Chrome 66

Operating system: Mac OS X

Edit: complete error (click me):

{
    "pma_version": "4.8.0.1",
    "browser_name": "CHROME",
    "browser_version": "66.0.3359.117",
    "user_os": "Mac",
    "server_software": "Apache/2.4.10 (Debian)",
    "user_agent_string": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.117 Safari/537.36",
    "locale": "fr",
    "configuration_storage": "enabled",
    "php_version": "5.6.33-0+deb8u1",
    "exception_type": "js",
    "exception": {
        "mode": "stack",
        "name": "ReferenceError",
        "message": "PMA_makegrid is not defined",
        "stack": [
            {
                "line": "292",
                "func": "",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLTableElement.",
                "line": "330",
                "column": "13",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "Function.each",
                "line": "2",
                "column": "2573",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "jQuery.fn.init.each",
                "line": "2",
                "column": "1240",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "329",
                "column": "29",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.new_func",
                "line": "248",
                "column": "33",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.dispatch",
                "line": "2",
                "column": "41772",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.$event.dispatch",
                "line": "374",
                "column": "19",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.y.handle",
                "line": "2",
                "column": "39791",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "Object.trigger",
                "line": "2",
                "column": "69551",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "2",
                "column": "70146",
                "uri": "index.php?v=4.8.0.1",
                "scriptname": "index.php"
            }
        ],
        "incomplete": "false",
        "partial": "true",
        "uri": "index.php?"
    },
    "script_name": "index.php",
    "microhistory": null
}

williamdes · 2018-11-27T22:05:20Z

@BarthDELUY @jizhidemowang Any idea on how to reproduce this step by step ?

williamdes · 2018-12-01T20:34:47Z

Using 4.8.x

Details

{
    "pma_version": "4.8.4-dev",
    "browser_name": "CHROME",
    "browser_version": "70.0.3538.103",
    "user_os": "Linux",
    "server_software": "nginx/1.10.3",
    "user_agent_string": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.103 Safari/537.36 Vivaldi/2.1.1337.47",
    "locale": "fr",
    "configuration_storage": "enabled",
    "php_version": "7.2.9-1+0~20180910100512.5+stretch~1.gbpdaac35",
    "exception_type": "js",
    "exception": {
        "mode": "stack",
        "name": "ReferenceError",
        "message": "PMA_makegrid is not defined",
        "stack": [
            {
                "func": "HTMLTableElement.",
                "line": "338",
                "column": "13",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "Function.each",
                "line": "2",
                "column": "2573",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "jQuery.fn.init.each",
                "line": "2",
                "column": "1240",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "337",
                "column": "29",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.new_func",
                "line": "248",
                "column": "33",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.dispatch",
                "line": "2",
                "column": "41772",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.$event.dispatch",
                "line": "374",
                "column": "19",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.y.handle",
                "line": "2",
                "column": "39791",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "Object.trigger",
                "line": "2",
                "column": "69551",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "2",
                "column": "70146",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            }
        ],
        "uri": "index.php?"
    },
    "script_name": "index.php",
    "microhistory": null
}

williamdes · 2018-12-02T17:39:47Z

Details

{
    "pma_version": "4.8.4-dev",
    "browser_name": "CHROME",
    "browser_version": "70.0.3538.103",
    "user_os": "Linux",
    "server_software": "nginx/1.10.3",
    "user_agent_string": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.103 Safari/537.36 Vivaldi/2.1.1337.47",
    "locale": "en",
    "configuration_storage": "enabled",
    "php_version": "7.2.12-1+0~20181112102304.11+stretch~1.gbp55f215",
    "exception_type": "js",
    "exception": {
        "mode": "stack",
        "name": "ReferenceError",
        "message": "PMA_makegrid is not defined",
        "stack": [
            {
                "func": "HTMLTableElement.",
                "line": "338",
                "column": "13",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "Function.each",
                "line": "2",
                "column": "2573",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "jQuery.fn.init.each",
                "line": "2",
                "column": "1240",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "337",
                "column": "29",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.new_func",
                "line": "248",
                "column": "33",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.dispatch",
                "line": "2",
                "column": "41772",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.$event.dispatch",
                "line": "374",
                "column": "19",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDocument.y.handle",
                "line": "2",
                "column": "39791",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "Object.trigger",
                "line": "2",
                "column": "69551",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            },
            {
                "func": "HTMLDivElement.",
                "line": "2",
                "column": "70146",
                "uri": "index.php?v=4.8.4-dev",
                "scriptname": "index.php"
            }
        ],
        "uri": "index.php?"
    },
    "script_name": "index.php",
    "microhistory": null
}

williamdes · 2018-12-25T18:15:08Z

Param	Value
Error Type	ReferenceError
Error Message	PMA_makegrid is not defined
Exception Type	js
phpMyAdmin version	4.8.4
Incident count	61
Link	Report#54274

This comment is posted automatically by phpMyAdmin's error-reporting-server.

williamdes · 2018-12-25T18:20:55Z

Param	Value
Error Type	ReferenceError
Error Message	PMA_makegrid is not defined
Exception Type	js
phpMyAdmin version	4.8.4
Incident count	2
Link	Report#54527

This comment is posted automatically by phpMyAdmin's error-reporting-server.

williamdes · 2019-04-04T22:03:30Z

while on "insert" page, with unfinished insertion I switched to "browse" page
Posed on reporting server

williamdes · 2019-05-27T22:32:22Z

This issue is so hard to reproduce..
Please help me reproduce it or make a fix

williamdes · 2019-06-11T07:46:48Z

Param	Value
Error Type	ReferenceError
Error Message	PMA_makegrid is not defined
Exception Type	js
phpMyAdmin version	4.9.0.1
Incident count	6
Link	Report#58140

This comment is posted automatically by phpMyAdmin's error-reporting-server.

williamdes · 2019-06-11T07:53:04Z

On sql.php?pos=0

scriptname: js/sql.js; line: 338; func: HTMLTableElement.; column: 13;

* triggered manually everytime the table of results is reloaded
 * @memberOf    jQuery
 */
$(document).on('makegrid', '.sqlqueryresults', function () {
    $('.table_results').each(function () {
        PMA_makegrid(this);
    });
});
 
/*
 * Attach a custom event for sticky column headings which will be

scriptname: js/sql.js; line: 337; func: HTMLDivElement.; column: 29;

* Attach the {@link makegrid} function to a custom event, which will be
 * triggered manually everytime the table of results is reloaded
 * @memberOf    jQuery
 */
$(document).on('makegrid', '.sqlqueryresults', function () {
    $('.table_results').each(function () {
        PMA_makegrid(this);
    });
});
 
/*

scriptname: js/vendor/jquery/jquery.event.drag-2.2.js; line: 374; func: HTMLDocument.$event.dispatch; column: 19;

scriptname: js/sql.js; line: 338; func: Anonymous function; column: 13;

* triggered manually everytime the table of results is reloaded
 * @memberOf    jQuery
 */
$(document).on('makegrid', '.sqlqueryresults', function () {
    $('.table_results').each(function () {
        PMA_makegrid(this);
    });
});
 
/*
 * Attach a custom event for sticky column headings which will be

scriptname: js/sql.js; line: 337; func: Anonymous function; column: 9;

* Attach the {@link makegrid} function to a custom event, which will be
 * triggered manually everytime the table of results is reloaded
 * @memberOf    jQuery
 */
$(document).on('makegrid', '.sqlqueryresults', function () {
    $('.table_results').each(function () {
        PMA_makegrid(this);
    });
});
 
/*

scriptname: js/vendor/jquery/jquery.event.drag-2.2.js; line: 374; func: $event.dispatch; column: 2;

williamdes · 2019-06-22T20:49:21Z

Param	Value
Error Type	ReferenceError
Error Message	makeGrid is not defined
Exception Type	js
phpMyAdmin version	5.0.0-dev
Incident count	2
Link	Report#58612

This comment is posted automatically by phpMyAdmin's error-reporting-server.

williamdes · 2019-12-25T14:02:16Z

Still had it but could not reproduce it more than one time

williamdes · 2020-01-03T20:09:45Z

After months, maybe years of trying to reproduce this issue I finally got a procedure:

https://demo.phpmyadmin.net/QA_5_0/tbl_change.php?db=world&table=City
CTRL+F5 (only if you went to "Insert" tab manually or can not trigger error)
click on table Country on the left bar
see the error

cc @yashrajbothra can you please try to fix it ?

yashrajbothra · 2020-01-03T20:15:04Z

I have started working on the issue.I will try my best to fix it.

williamdes · 2020-01-04T08:44:59Z

The demo server credentials are root and no password

yashrajbothra · 2020-01-04T08:46:53Z

Thanks @williamdes

yashrajbothra · 2020-01-04T12:02:33Z

Hey @williamdes which branch should i take as base?

williamdes · 2020-01-04T16:04:46Z

@yashrajbothra QA_5_0 should be used as a base

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>

Signed-off-by: William Desportes <williamdes@wdes.fr>

BarthDELUY changed the title ~~JS Exception "PMA_makegrid is not defined" on homepage when clicking a table name on Chrome 66 on Mac OS X~~ JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name on Chrome 66 on Mac OS X May 16, 2018

williamdes mentioned this issue Oct 14, 2018

Operate after a long period of inactivity PMA_makegrid is not defined #14662

Closed

williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Nov 27, 2018

williamdes added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Dec 1, 2018

williamdes changed the title ~~JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name on Chrome 66 on Mac OS X~~ JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name Dec 2, 2018

williamdes added the help wanted label Dec 2, 2018

williamdes added this to the 4.8.4 milestone Dec 2, 2018

ibennetch modified the milestones: 4.8.4, 4.8.5 Dec 11, 2018

ibennetch modified the milestones: 4.8.5, 4.8.6 Jan 26, 2019

williamdes removed this from the 4.8.6 milestone Apr 1, 2019

williamdes added this to n/a priority in issues Apr 29, 2019

williamdes mentioned this issue Jan 3, 2020

Fatal javascript error on clicking "Pick from Central Columns" #15741

Closed

williamdes assigned williamdes and unassigned williamdes Jan 3, 2020

williamdes added this to the 5.0.1 milestone Jan 3, 2020

yashrajbothra added a commit to yashrajbothra/phpmyadmin that referenced this issue Jan 4, 2020

phpmyadmin#14299 added makegrid.js file

2fef516

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>

yashrajbothra mentioned this issue Jan 4, 2020

Fixed error: makeGrid is undefined #15747

Merged

6 tasks

williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 4, 2020

williamdes self-assigned this Jan 6, 2020

williamdes added a commit that referenced this issue Jan 6, 2020

Add ChangeLog entry for #14299

5e6ca74

Signed-off-by: William Desportes <williamdes@wdes.fr>

williamdes closed this as completed in 12270a4 Jan 6, 2020

issues automation moved this from n/a priority to Closed Jan 6, 2020

github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name #14299

JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name #14299

BarthDELUY commented May 16, 2018 •

edited by williamdes

williamdes commented Nov 27, 2018

williamdes commented Dec 1, 2018 •

edited

williamdes commented Dec 2, 2018 •

edited

williamdes commented Dec 25, 2018

williamdes commented Dec 25, 2018

williamdes commented Apr 4, 2019

williamdes commented May 27, 2019

williamdes commented Jun 11, 2019

williamdes commented Jun 11, 2019 •

edited

williamdes commented Jun 22, 2019

williamdes commented Dec 25, 2019

williamdes commented Jan 3, 2020 •

edited

yashrajbothra commented Jan 3, 2020 •

edited

williamdes commented Jan 4, 2020

yashrajbothra commented Jan 4, 2020

yashrajbothra commented Jan 4, 2020

williamdes commented Jan 4, 2020

JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name #14299

JS Exception "PMA_makegrid is not defined" on index.php when clicking a table name #14299

Comments

BarthDELUY commented May 16, 2018 • edited by williamdes

Steps to reproduce

Expected behaviour

Actual behaviour

Server configuration

Client configuration

williamdes commented Nov 27, 2018

williamdes commented Dec 1, 2018 • edited

williamdes commented Dec 2, 2018 • edited

williamdes commented Dec 25, 2018

williamdes commented Dec 25, 2018

williamdes commented Apr 4, 2019

williamdes commented May 27, 2019

williamdes commented Jun 11, 2019

williamdes commented Jun 11, 2019 • edited

williamdes commented Jun 22, 2019

williamdes commented Dec 25, 2019

williamdes commented Jan 3, 2020 • edited

yashrajbothra commented Jan 3, 2020 • edited

williamdes commented Jan 4, 2020

yashrajbothra commented Jan 4, 2020

yashrajbothra commented Jan 4, 2020

williamdes commented Jan 4, 2020

BarthDELUY commented May 16, 2018 •

edited by williamdes

williamdes commented Dec 1, 2018 •

edited

williamdes commented Dec 2, 2018 •

edited

williamdes commented Jun 11, 2019 •

edited

williamdes commented Jan 3, 2020 •

edited

yashrajbothra commented Jan 3, 2020 •

edited