Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export table structure shows rows fields #14334

Closed
OlafvdSpek opened this issue May 28, 2018 · 12 comments
Closed

Export table structure shows rows fields #14334

OlafvdSpek opened this issue May 28, 2018 · 12 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Milestone

Comments

@OlafvdSpek
Copy link

Rows doesn't make sense if you only export structure..

pma

@williamdes williamdes added Bug A problem or regression with an existing feature help wanted newbie ui Issues relating to the user interface good first issue labels Oct 28, 2018
@pulunomoe
Copy link
Contributor

Hi, I would like to help with this issue. Could you please let me know the URL of the page that have this issue?

@pulunomoe
Copy link
Contributor

Thank you. I wonder if this will do?

2018-10-29 16_23_24-microsoft edge

@OlafvdSpek
Copy link
Author

There's already a structure, data or both control.. (down below).

@pulunomoe
Copy link
Contributor

Ah I see. Sorry about that. Working on it.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Oct 29, 2018
AbdoHammam added a commit to AbdoHammam/phpmyadmin that referenced this issue Nov 3, 2018
AbdoHammam added a commit to AbdoHammam/phpmyadmin that referenced this issue Nov 3, 2018
AbdoHammam added a commit to AbdoHammam/phpmyadmin that referenced this issue Nov 3, 2018
@AbdoHammam AbdoHammam mentioned this issue Nov 3, 2018
6 tasks
@ibennetch
Copy link
Member

You're not wrong, but since the row selector comes first this is a bit more difficult than just showing or hiding it (simply hiding the row selector when the user toggles to structure is pointless since it will make the whole UI slide up and the user has already made a decision about this).

I think the best solution is to move the row selector down, perhaps as the next thing after the data/structure/both selector.

@Ganofins
Copy link

https://demo.phpmyadmin.net/master-config-nopmadb/tbl_export.php?db=Restaurante&table=Horarios&single_table=true

hey there is not any db named as Restaurante

@williamdes
Copy link
Member

@Ganofins That doesn't matter because this issue is on all table exports.

@Ganofins
Copy link

@williamdes can you please tell me more about the issue

@williamdes
Copy link
Member

@Ganofins
Demo servers (root, no password)

Steps

  • Navigate to a database
  • Navigate to a table
  • Go to "Export"
  • Choose the radio "Structure" in "Format-specific options:"

"Rows: " should be hidden when structure is checked.

@Ganofins

@abhishekvirat0
Copy link

Is the problem solved or you need help ??

@williamdes
Copy link
Member

@abhikandoi2000 You can find another issue if you want to contribute :)
This one already has a pull-request to fix this issue.

williamdes added a commit that referenced this issue Apr 1, 2019
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Apr 1, 2019
@williamdes williamdes added this to the 4.8.6 milestone Apr 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants