Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript report loop / flood server with report requests #14359

Closed
williamdes opened this issue Jun 4, 2018 · 0 comments
Closed

javascript report loop / flood server with report requests #14359

williamdes opened this issue Jun 4, 2018 · 0 comments
Assignees
@MauricioFauth
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone
5.0.0

Comments

@williamdes
Copy link
Member

williamdes commented Jun 4, 2018 •
edited

Steps to reproduce

  1. Install phpMyAdmin 5.0.0-dev
  2. block request to js/messages.php in chrome dev tools
  3. Or break javascript :

In js/messages.php :
change on line 766 (remove simple coma) :

, " ' ;\n"; to , " ;\n";

Warning

This issue will create an infinite loop of sending reports to server, be prepared to close this browser tab.
Open the browser developer console to see all the requests.

Expected behaviour

Send one report or none

Actual behaviour

Sending reports (thousands, forever)

Error

error_report.js?v=5.0.0-dev:124 Uncaught ReferenceError: PMA_messages is not defined
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Jun 4, 2018
@williamdes
Prevent reposting of javascript errors
fa303ee 
Closes: phpmyadmin#14359
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Jun 5, 2018
Merged
@MauricioFauth MauricioFauth added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Jun 6, 2018
@MauricioFauth MauricioFauth self-assigned this Jun 6, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Jun 6, 2018
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Mar 16, 2019
@williamdes
Fix, prevent multiple error reporting modals
27f7b7a 
See: fa303ee
Seee: phpmyadmin#14359
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 16, 2019
@williamdes
Add ChangeLog entry for #14359
e33f806 
Signed-off-by: William Desportes <williamdes@wdes.fr>
apoorvkhare07 pushed a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@williamdes @apoorvkhare07
Fix, prevent multiple error reporting modals
479b239 
See: fa303ee
Seee: phpmyadmin#14359
Signed-off-by: William Desportes <williamdes@wdes.fr>
apoorvkhare07 pushed a commit to apoorvkhare07/phpmyadmin that referenced this issue Mar 19, 2019
@williamdes @apoorvkhare07
Add ChangeLog entry for phpmyadmin#14359
a14d00b 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue Mar 20, 2019
Closed
@williamdes williamdes changed the title [5.0.0-dev] javascript report loop / flood server with report requests javascript report loop / flood server with report requests Apr 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@MauricioFauth @williamdes