insert_rows keypress Enter behavior

[kampalex]

Steps to reproduce

1. Select table in database overview
2. Choose table record insertion
3. On the bottom, insert different number of record to insert (like 6), press [Enter] instead of clicking outside this input:number (id=insert_rows)

Expected behaviour

In-page extension of insertable records, like the blur event

Actual behaviour

Message shows: 'No databases selected'
Click on table name (at top)
Message appears:
Notice in ./libraries/db_table_exists.inc.php#20
Undefined variable: db

Backtrace

./tbl_change.php#25: require_once(./libraries/db_table_exists.inc.php)
./libraries/classes/InsertEdit.php#2147: include(./tbl_change.php)
./tbl_replace.php#55: PhpMyAdmin\InsertEdit->isInsertRow()

Click on table again and issue disappears

Server/Client configuration

Ubuntu 18.04
Apache/2.4.29
MariaDB 10.1.29
PHP 7.2.5
phpMyAdmin 4.8.1
Google Chrome 69.0.3452.0 dev x64

[aroralakshya]

Have you tried defocusing that textbox?? It works. Maybe it shouldn't or maybe they have made it that way, if yes, then the action on pressing enter could be disabled. OR action on defocusing could be disabled and it will work only on pressing enter.

[kampalex]

As said I defocused (which triggers the blur event) the field, which gives me the extra record insertions.
I suggest an event listener 'keydown', on [Enter] key it will trigger the blur event, but only if the field does contain a valid number.

[williamdes]

@kampalex I had this issue !

NOTICE: PHP message: PHP Fatal error:  Uncaught TypeError: strlen() expects parameter 1 to be string, null given in /mnt/Dev/phpmyadmintest/libraries/db_table_exists.inc.php:21
Stack trace:
#0 /mnt/Dev/phpmyadmintest/tbl_change.php(27): require_once()
#1 /mnt/Dev/phpmyadmintest/libraries/classes/InsertEdit.php(2165): include('/mnt/Dev/phpmya...')
#2 /mnt/Dev/phpmyadmintest/tbl_replace.php(58): PhpMyAdmin\InsertEdit->isInsertRow()
#3 {main}
  thrown in /mnt/Dev/phpmyadmintest/libraries/db_table_exists.inc.php on line 21

[kampalex]

Issue still appears in PMA 4.8.3 (under PHP 7.2.12).

...dived into it

@williamdes This is probably because of missing 'global $db;' (or not used $GLOBALS['db'] as used in other files, or it doesn't exists yet) in db_table_exists.inc.php. But when I global it, it does (in this issue) lead to more failures due to missing table variable. When also declaring table as global, more issues occur due expected variables. Stopped there...

I still suggest to implement the already provided mentioned 'JS [Enter] triggers keypress' for this field. Fixing in PHP costs more efforts (but maybe this can be a kind of treasure hunt for more bugs/unwanted behavior).

Origin of issue is 'different input value of insert_rows', which includes the 'tbl_change.php' file.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.