Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal javascript error while adding index to a new column #14402

Closed
aroralakshya opened this issue Jun 18, 2018 · 2 comments
Closed

Fatal javascript error while adding index to a new column #14402

aroralakshya opened this issue Jun 18, 2018 · 2 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Milestone
4.9.0.1

Comments

@aroralakshya
Copy link
Contributor

aroralakshya commented Jun 18, 2018 •
edited by williamdes

Steps to reproduce

  1. Create a new column in an existing table.
  2. Select PRIMARY in the drop down to add index, deselect primary from the drop down.
  3. PRIMARY still appears in the link below this dropdown, click the link.

Expected behaviour

Should show the dialog to select index.

Actual behaviour

Fatal javascript error, cannot read property undefined of null

Server configuration

Operating system:
ubuntu 16.04

Web server:
apache 2.4.29

Database:
mariadb 10.1.30

PHP version:
7.1.14

phpMyAdmin version:
5.0.0-dev & 4.8.4

Client configuration

Browser:
chrome 66.0.3359.117
@aswaniprakash
Copy link
Contributor

@nulll-pointer Shouldn't we just remove the link when we select none ('---') from the index dropdown and show the link only when other values are selected?

@williamdes
Copy link
Member

Successfully reproduced on demo servers !
Demo servers (root, no password)

@williamdes williamdes added Bug A problem or regression with an existing feature help wanted ui Issues relating to the user interface good first issue labels Nov 27, 2018
kartik1000 referenced this issue in kartik1000/phpmyadmin Feb 6, 2019
@kartik1000
Fix#14402 JavascriptError-adding Index to a new column
b7c15b6 
Signed-off-by: Kartik Kathuria [kathuriakartik0@gmail.com](mailto:kathuriakartik0@gmail.com)
This was referenced Feb 6, 2019
Closed
Closed
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 7, 2019
williamdes added a commit that referenced this issue Mar 1, 2019
@williamdes
Add ChangeLog entry for #14402
8162313 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Mar 1, 2019
@williamdes williamdes added this to the 4.8.6 milestone Mar 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
williamdes added a commit that referenced this issue Nov 12, 2023
@williamdes
Fix #14402 - PRIMARY label is not removed when two PRIMARY where defined
c2967d6 
Added in #14984

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted ui Issues relating to the user interface
Projects
None yet
Milestone
4.9.0.1
Development

Successfully merging a pull request may close this issue.

Fixed Error 14402 Javascript Error-adding index to a new column kartik1000/phpmyadmin
3 participants
@williamdes @aroralakshya @aswaniprakash