Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"DROP VIEW" and "IF NOT EXISTS" checkboxes have no effect when exporting views #14404

Closed
JayEn84 opened this issue Jun 19, 2018 · 0 comments
Closed
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone

Comments

@JayEn84
Copy link
Contributor

JayEn84 commented Jun 19, 2018

Steps to reproduce

  1. Navigate to the Export page of a view
  2. Change the export method from quick to custom
  3. Activate the checkboxes for "DROP VIEW" and/or "IF NOT EXISTS"

Expected behaviour

  1. I expect a DROP VIEW query prior to the CREATE query when activating the DROP VIEW checkbox.
  2. I did not expect an "IF NOT EXISTS" checkbox as this seems impossible when creating a view.

Actual behaviour

There is no difference in the output no matter if these checkboxes are checked or not.

Suggestion for improvement

Replace the "IF NOT EXISTS" checkbox by something like a "REPLACE" checkbox in order to achieve an output query like "`CREATE OR REPLACE VIEW view_name"

Server configuration

Operating system:
Windows 7

Web server:
Apache 2.4.16

Database:
MySQL 5.6.17

PHP version:
5.6.12

phpMyAdmin version:
Tested with 5.7.7 and 5.8.1

aswaniprakash added a commit to aswaniprakash/phpmyadmin that referenced this issue Jul 3, 2018
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
@williamdes williamdes added Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Oct 11, 2018
MauricioFauth pushed a commit that referenced this issue Oct 29, 2018
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
MauricioFauth added a commit that referenced this issue Oct 29, 2018
* Fix tests

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
MauricioFauth added a commit that referenced this issue Oct 29, 2018
Drop view and or replace added to exporting view #14404
@MauricioFauth MauricioFauth self-assigned this Oct 29, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Oct 29, 2018
MauricioFauth added a commit that referenced this issue Oct 31, 2018
Related to #14404

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants