Execute button is disabled for routines

[marcomarsala]

Steps to reproduce

1. Create a stored procedure:

DELIMITER $$
CREATE DEFINER=`wordpress_12`@`localhost` PROCEDURE `Sconto su alloggio`(IN `percentuale` DECIMAL(4,2), IN `anno` SMALLINT, IN `alloggio` VARCHAR(16), IN `fascia` CHAR(5))
    NO SQL
    COMMENT 'Applica sconto percentuale alle fasce di un alloggio'
SELECT 1$$
DELIMITER ;

2. Grant EXECUTE to another user:

GRANT EXECUTE ON PROCEDURE `wordpress_f2`.`Sconto su alloggio` TO 'hwreport'@'localhost';

3. Login with that user.

Expected behaviour

Execute button is enabled for the routine.

Actual behaviour

Execute button is disabled for the routine.

Server configuration

Operating system: Ubuntu 16.04

Web server: Apache 2.4.18

Database: MySQL 5.7.22

PHP version: 7.1.13

phpMyAdmin version: 4.8.2

Client configuration

Browser: Chrome 67.0.3396.99 (64 bit)

Operating system: Windows 10.0.17134 build 17134

[williamdes]

@marcomarsala I can not reproduce this issue.
Can you please send the output of:

SHOW CREATE PROCEDURE `wordpress_f2`.`Sconto su alloggio`;

[marcomarsala]

This happens with user with only EXECUTE permission.

[bahl24]

@marcomarsala Which lang pack are you using, I am having difficulty reproducing the issue?

[bahl24]

I was able to successfully replicate the issue, and yes the 'Execute' button is not active.

[bahl24]

@williamdes @marcomarsala @ibennetch Though 'execute' button is inactive but I am able to CALL the procedure both from system terminal as well as console given on phpMyAdmin page.


I am a new to phpMyAdmin development but would like to work on this issue
(Note - I modified the names to English as I can't understand Italian)

[bahl24]

I’d like to try fixing this.

[williamdes]

@bahl24 Go ahead ;)

[bahl24]

@williamdes @ibennetch @MauricioFauth
I worked on this issue and found that error is in Util::currentUserHasPrivilege due to which execute button is not displayed. Infact, it has been already mentioned in the following comment

[bahl24]

This is not a permanent fix for the issue but in order to justify
There is a problem with Util::currentUserHasPrivilege(): // There is a problem with Util::currentUserHasPrivilege(): // it does not detect all kinds of privileges, for example // it does not detect all kinds of privileges, for example // a direct privilege on a specific routine. So, at this point, // a direct privilege on a specific routine. So, at this point, // we show the Execute link, hoping that the user has the correct rights.

this fix is the only solution until Util::currentUserHasPrivilege() is fully fixed

[victorphoenix3]

will try to debug this

[victorphoenix3]

@williamdes The issue lies with getDefinition function in DatabaseInterface.php which returns a false for every user who is not named in the DEFINER clause for the procedure. Thus, execute button is not available even the user has privileges.

will it be right to override this function ?

[williamdes]

will it be right to override this function ?

From what I understand It would be right

[williamdes]

CALL `Sconto su alloggio`(1, 1, 1, 1);

[rajat315315]

Fixed.

[williamdes]

I could not validate any PR done for this issue. And I tried many versions and even 5.7.22.
Please help me

Using a docker image from the hub with a basic user. (And also tested with users I created)