Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ignore" check box (in INSERT tab) does not uncheck when all the fields are edited through popup windows #14502

Closed
diyoyo opened this issue Jul 21, 2018 · 5 comments · Fixed by #17082
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie
Projects
Milestone

Comments

@diyoyo
Copy link

diyoyo commented Jul 21, 2018

Steps to reproduce

  1. Create a table with let's say 2 columns with foreign key
  2. In the related tables (those referred to by the keys), add many entries, so that it reaches the threshold of PhpMyAdmin where the < select > becomes a popup, for displaying the options.

Expected behaviour

The "Ignore" checkbox should become unchecked for that entry, since fields are filled.

Actual behaviour

The js listener does not understand that fields have been filled, and thus, the "Ignore" button is not set to the unchecked state!

Server configuration

phpMyAdmin version: 4.8.3, 5.0.0-dev

@williamdes williamdes added the Bug A problem or regression with an existing feature label Nov 27, 2018
@williamdes
Copy link
Member

williamdes commented Nov 27, 2018

Demo servers (root, no password)

Test data

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";

CREATE TABLE a (
  a varchar(3) NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

INSERT INTO a (a) VALUES
('\"r\"'),
('&1');

CREATE TABLE b (
  aa varchar(3) NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1;

INSERT INTO b (aa) VALUES
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('\"r\"'),
('&1'),
('&1'),
('&1'),
('&1'),
('&1'),
('\'-y'),
('\'-y'),
('\'-y'),
('\'-y'),
('\'-y'),
('(\'-'),
('(\'-'),
('(\'-'),
('(\'-'),
('(\'-'),
('(uq'),
('(uq'),
('(uq'),
('(uq'),
('(uq'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('-è-'),
('1'),
('1'),
('1'),
('1'),
('1'),
('2'),
('2'),
('2'),
('2'),
('2'),
('2'),
('2'),
('2'),
('2'),
('2'),
('22'),
('22'),
('22'),
('22'),
('22'),
('222'),
('222'),
('222'),
('222'),
('222'),
('\"'),
('\"'),
('\"'),
('\"'),
('\"'),
('3'),
('3'),
('3'),
('3'),
('3'),
('33'),
('33'),
('33'),
('33'),
('33'),
('333'),
('333'),
('333'),
('333'),
('333'),
('333'),
('333'),
('333'),
('333'),
('333'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('528'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('85H'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('889'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('AZD'),
('ddd'),
('ddd'),
('ddd'),
('ddd'),
('ddd'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DOL'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('DUJ'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('EDE'),
('eee'),
('eee'),
('eee'),
('eee'),
('eee'),
('ERG'),
('ERG'),
('ERG'),
('erg'),
('ERG'),
('ERG'),
('ERG'),
('erg'),
('ERG'),
('ERG'),
('ERG'),
('erg'),
('ERG'),
('ERG'),
('ERG'),
('erg'),
('ERG'),
('ERG'),
('ERG'),
('erg'),
('ezf'),
('ezf'),
('ezf'),
('ezf'),
('ezf'),
('fbr'),
('fbr'),
('fbr'),
('fbr'),
('fbr'),
('fef'),
('FEF'),
('FEF'),
('FEF'),
('fef'),
('FEF'),
('FEF'),
('FEF'),
('fef'),
('FEF'),
('FEF'),
('FEF'),
('fef'),
('FEF'),
('FEF'),
('FEF'),
('fef'),
('FEF'),
('FEF'),
('FEF'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FET'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRE'),
('FRF'),
('FRF'),
('FRF'),
('frf'),
('FRF'),
('FRF'),
('FRF'),
('frf'),
('FRF'),
('FRF'),
('FRF'),
('frf'),
('FRF'),
('FRF'),
('FRF'),
('frf'),
('FRF'),
('FRF'),
('FRF'),
('frf'),
('ilu'),
('ilu'),
('ilu'),
('ilu'),
('ilu'),
('iul'),
('iul'),
('iul'),
('iul'),
('iul'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfe'),
('rfr'),
('rfr'),
('rfr'),
('rfr'),
('rfr'),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('RG('),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rg5'),
('rgu'),
('rgu'),
('rgu'),
('rgu'),
('rgu'),
('rh\''),
('rh\''),
('rh\''),
('rh\''),
('rh\''),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('rve'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('SXS'),
('uil'),
('uil'),
('uil'),
('uil'),
('uil'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('Y(-'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zdd'),
('zr'),
('zr'),
('zr'),
('zr'),
('zr');

CREATE TABLE `issue-14274` (
  id int(11) NOT NULL,
  z geometry NOT NULL,
  y point DEFAULT NULL,
  x linestring DEFAULT NULL,
  w multipolygon DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

;


ALTER TABLE a
  ADD KEY a (a);

ALTER TABLE b
  ADD KEY aa (aa);

ALTER TABLE `issue-14274`
  ADD PRIMARY KEY (id);


ALTER TABLE `issue-14274`
  MODIFY id int(11) NOT NULL AUTO_INCREMENT;


ALTER TABLE a
  ADD CONSTRAINT a_ibfk_1 FOREIGN KEY (a) REFERENCES `b` (aa);

@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes moved this from To be sorted to to be fixed soon in issues May 3, 2019
@williamdes williamdes added this to the 5.1.2 milestone Jul 27, 2021
@williamdes
Copy link
Member

cc @anny21

This is a good one and occurs also with the GIS edit modal

@anny21
Copy link
Contributor

anny21 commented Aug 16, 2021

Thank you @williamdes.. i'm looking into it, I will send you a message on twitter soon. Thank you

@anny21
Copy link
Contributor

anny21 commented Aug 16, 2021

@williamdes I sent you a message on twitter 😭

@williamdes williamdes self-assigned this Aug 17, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 17, 2021
@williamdes
Copy link
Member

Thank you @anny21 for your fix #17082 !
It works perfectly !

williamdes added a commit to anny21/phpmyadmin that referenced this issue Aug 18, 2021
…e value

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 18, 2021
…t field to uncheck the "ignore" checkbox

Fixes: #14502
Pull-request: #17082

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Aug 18, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from to be fixed soon to Closed Aug 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie
Projects
issues
  
Closed
3 participants