Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript events not activating when input comes from mouse or browser autocomplete #14503

Closed
diyoyo opened this issue Jul 21, 2018 · 6 comments
Assignees
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Milestone

Comments

@diyoyo
Copy link

diyoyo commented Jul 21, 2018

Steps to reproduce

  1. Try to fill whatever form of phpMyAdmin by other means than the keyboard. For example, make your browser autocomplete your word
  2. Wait for the JS event to perform

Example: in the SQL tab, try to assign a name to your query in the bookmark field, then let the browser autocomplete.

Expected behaviour

JS event is triggered and 2 new checkboxes should appear for additional options

Actual behaviour

JS events are not triggered and the checkboxes are not showing.

Server configuration

phpMyAdmin version:
4.8.2

Client configuration

Browser:
Firefox, Chrome
Operating system:
Windows10

@ibennetch
Copy link
Member

This is an interesting problem, although a bit of an edge case.

Stack overflow suggests using 'on input' instead of keydown and keyup events to detect changes in these situations.

@ibennetch ibennetch changed the title General JS Event Bug JavaScript events not activating when input comes from mouse or browser autocomplete Jul 31, 2018
@williamdes
Copy link
Member

Reproduced on demo servers (root, no password)

Steps

  • Go to SQL tab
  • Type a name in bookmark field
  • The checkboxes show
  • Empty the bookmark field
  • The checkboxes hide
  • Paste some text
  • The checkboxes are not shown

Screenshot

Screenshot

@williamdes williamdes added Bug A problem or regression with an existing feature newbie ui Issues relating to the user interface good first issue labels Nov 28, 2018
@GaurangTandon
Copy link

It seems this issue has been fixed on 5.0.0-dev. I have checked using all methods: type through physical keyboard, type through virtual keyboard, type through paste. All correctly display checkboxes as soon data is typed and hide them once all data is deleted.

@nervaccio
Copy link

5.0.0-dev
it doesn't even show up.

4.8.x
Checkboxes doesn't shows when you paste some text with: right-click + paste. If you paste with CTRL+V it behave as expected.

My config for this test
Ubuntu 18.04
Firefox Quantum 63.0.3
Chrome Version 71.0.3578.80 (Official Build) (64-bit)
Chromium Version 71.0.3578.80 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)

@GaurangTandon
Copy link

GaurangTandon commented Dec 12, 2018

Hi @nervaccio, I can successfully see the checkboxes on 5.0.0-dev on Ubuntu 18.04 with Version 69.0.3497.81 (Official Build) (64-bit).
Here's a video of the same three methods I described earlier.

@nmilo
Copy link
Contributor

nmilo commented Jan 19, 2019

Made a PR #14876 to fix last task with this issue. Expected functionality is now present with right click, copy, in addition to previous methods.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 19, 2019
williamdes added a commit that referenced this issue Mar 2, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Mar 2, 2019
@williamdes williamdes added this to the 4.8.6 milestone Mar 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete newbie ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants