Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Propose table structure" on MySQL 8.0 #14621

Closed
lem9 opened this issue Sep 20, 2018 · 4 comments
Closed

"Propose table structure" on MySQL 8.0 #14621

lem9 opened this issue Sep 20, 2018 · 4 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.0.1

Comments

@lem9
Copy link
Contributor

lem9 commented Sep 20, 2018

On Table > Structure, we have a choice "Propose table structure" which uses a query containing "PROCEDURE ANALYSE()". This clause has been removed in MySQL 8.0, so the choice should not be displayed for MySQL >= 8.0.

Seen in phpMyAdmin 4.8.3.
@MauricioFauth
Copy link
Member

PROCEDURE ANALYSE() syntax is removed.

Reference: https://dev.mysql.com/doc/refman/8.0/en/mysql-nutshell.html#mysql-nutshell-removals

@OlafvdSpek
Copy link

OlafvdSpek commented Sep 23, 2018 •
edited

Has this feature ever be really useful?

@pulunomoe
Copy link
Contributor

Hi, I want to help with this issue.

@pulunomoe pulunomoe mentioned this issue Oct 30, 2018
Merged
6 tasks
@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 9, 2018
@williamdes williamdes added this to Needs triage in issues via automation May 18, 2019
@williamdes williamdes added Bug A problem or regression with an existing feature and removed help wanted labels May 18, 2019
@williamdes williamdes self-assigned this May 18, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 18, 2019
@williamdes williamdes moved this from Needs triage to ready to merge in issues May 18, 2019
williamdes added a commit that referenced this issue May 18, 2019
@williamdes
Fix #14621 - remove "Propose table structure" on MySQL 8.0
1895900 
Fixes: #14621
Pull-request: #14697
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue May 18, 2019
@williamdes
Add ChangeLog entry for #14621
e18f697 
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue May 18, 2019
@williamdes
Fix phpmyadmin#14621 - add "Propose table structure" on MariaDB
35fcea7 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed May 18, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.0.1
Development

No branches or pull requests
5 participants
@MauricioFauth @lem9 @pulunomoe @OlafvdSpek @williamdes