Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum with comma produces incorrect search dropdown #14631

Closed
ChrisHSandN opened this issue Sep 26, 2018 · 2 comments
Closed

Enum with comma produces incorrect search dropdown #14631

ChrisHSandN opened this issue Sep 26, 2018 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature
Projects
Milestone

Comments

@ChrisHSandN
Copy link

ChrisHSandN commented Sep 26, 2018

Describe the bug

When a comma is used within the value of an ENUM field the search dropdown incorrectly splits this.

To Reproduce

Steps to reproduce the behavior:

CREATE TABLE `1_test` (
 `foo` enum('foo,bar') COLLATE utf8_unicode_ci NOT NULL,
 PRIMARY KEY (`foo`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

From search tab:
Dropdown next to field foo shows separate values for ‘foo’, ‘bar’ (incorrect)

From structure tab
Change field foo > Edit ENUM/SET values > shows ‘foo,bar’ as single value (correct)

Expected behavior

However the structure tab is splitting the ENUM needs to be applied to the search tab dropdown, rather than just exploding around comma as it currently seems to do.

Screenshots

image
image

Server configuration

  • Database version: 10.2.15-MariaDB
  • phpMyAdmin version: 4.8.2
@lem9
Copy link
Contributor

lem9 commented Sep 26, 2018

The Insert page is correct; it uses Util::parseEnumSetValues() which correctly parses commas inside a quoted string. The Search page is buggy; it uses templates/table/search/input_box.twig which splits on the comma.

@williamdes
Copy link
Member

Affects master and QA_4_8

@williamdes williamdes added the Bug A problem or regression with an existing feature label Sep 26, 2018
@MauricioFauth MauricioFauth added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 12, 2018
@williamdes williamdes removed the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 1, 2019
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes moved this from To be sorted to Reproduced in issues May 3, 2019
@williamdes williamdes self-assigned this Jul 27, 2021
@williamdes williamdes added this to the 5.1.2 milestone Jul 27, 2021
williamdes added a commit that referenced this issue Jul 27, 2021
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Jul 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Development

No branches or pull requests

4 participants