Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security confirm() before running UPDATE or DELETE statement without WHERE condition #14677

Closed
Defcon0 opened this issue Oct 18, 2018 · 2 comments · Fixed by #14685
Closed

Security confirm() before running UPDATE or DELETE statement without WHERE condition #14677

Defcon0 opened this issue Oct 18, 2018 · 2 comments · Fixed by #14685
Assignees
@MauricioFauth
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone
5.0.0

Comments

@Defcon0
Copy link

Defcon0 commented Oct 18, 2018

Is your feature request related to a problem? Please describe.

Today I (again) had data loss because I executed an UPDATE statement and forgot the WHERE condition. I know, it was my fault, but nobody is perfect I guess.

Describe the solution you'd like

The ideal solution in my opinion would be to have a short confirm like "Do you really want to run the statement without a WHERE condition?". Of course, this must be an option which one could deactivate.

Would that be possible? I know I'm not the only one that has had trouble in this kind of situation ;-)
@WellingtonBraga WellingtonBraga mentioned this issue Oct 23, 2018
Merged
6 tasks
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Oct 23, 2018
@MauricioFauth MauricioFauth self-assigned this Nov 9, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Nov 9, 2018
MauricioFauth added a commit that referenced this issue Nov 9, 2018
@MauricioFauth
Add ChangeLog entry for #14677
255acf7 
[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@Defcon0
Copy link
Author

Defcon0 commented Nov 9, 2018

Awesome, thanks @WellingtonBraga :-)

@WellingtonBraga
Copy link

You're welcome. Glad for being useful.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MauricioFauth MauricioFauth

Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Security confirm() before running UPDATE WellingtonBraga/phpmyadmin
4 participants
@MauricioFauth @Defcon0 @WellingtonBraga @williamdes