Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper message in Show Hidden Navigation Tree Items #14683

Closed
nakshatra1997 opened this issue Oct 21, 2018 · 6 comments · Fixed by #14690
Closed

Improper message in Show Hidden Navigation Tree Items #14683

nakshatra1997 opened this issue Oct 21, 2018 · 6 comments · Fixed by #14690
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@nakshatra1997
Copy link
Contributor

Describe the problem

In the directory structure, there is a provision of hiding tables. However, after unhiding all the tables, the screen is somewhat like this (see the screenshot)-

tables

Describe the solution you'd like

If all the tables are unhidden by the user, the prompt should leave a proper message like "No Hidden Tables Exists" or "Table:None" and if we don't want to show any message ,then we can automatically close the prompt.

Additional context

  • phpMyAdmin version:5.0.0-dev
@computerManiac
Copy link

Hey @nakshatra1997 , is this what you expect ?
screenshot_2018-10-23 localhost localhost phpmyadmin 5 0 0-dev 1

This will be my first contribution to phpMyAdmin, so your comments are much appreciated.

@lem9
Copy link
Contributor

lem9 commented Oct 23, 2018

Better remove completely the dialog when the last table is unhidden.

@nakshatra1997
Copy link
Contributor Author

@lem9 okay i am working on it..

@nakshatra1997
Copy link
Contributor Author

@computerManiac actually i was already working on it..but thanx anyways u paid attention to it.. :)

@computerManiac
Copy link

@nakshatra1997 sorry about that mate, should I close my PR or continue making changes to it ?

@nakshatra1997
Copy link
Contributor Author

@computerManiac it's fine... let it be no issue :)

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Oct 27, 2018
@MauricioFauth MauricioFauth self-assigned this Nov 5, 2018
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Nov 5, 2018
MauricioFauth added a commit that referenced this issue Nov 5, 2018
[CI skip]

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
5 participants