Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database tab Total collation #14695

Closed
jluisgarcia opened this issue Oct 30, 2018 · 10 comments
Closed

Database tab Total collation #14695

jluisgarcia opened this issue Oct 30, 2018 · 10 comments
Assignees
Labels
has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@jluisgarcia
Copy link

Describe the bug

A collation type is shown for the Total number of databases

Expected behavior

No collation type should be shown at all. As it is not related to any particular DB.

Screenshots

image

Server configuration

  • Operating system: Windows 8.1 (Local machine)
  • Web server: Apache 2.4.34
  • Database version: MariaDB 10.1.36
  • PHP version: 7.1.22
  • phpMyAdmin version: 4.8.3

Client configuration

  • Browser: Firefox Dev version
  • Operating system: Windows 8.1
@Gaurav-Punjabi
Copy link
Contributor

Can I solve this issue ?

@OlafvdSpek
Copy link

I think this is the default collation type..

@williamdes
Copy link
Member

@Gaurav-Punjabi Yes, you can create a pull-request :)

@williamdes williamdes added the ui Issues relating to the user interface label Oct 30, 2018
@Gaurav-Punjabi
Copy link
Contributor

Gaurav-Punjabi commented Oct 31, 2018

@williamdes Hey, I have solved the above issue. I'm a newbie here so can you guide me on which target branch should I make this pull request what other things should I do.

@williamdes
Copy link
Member

williamdes commented Oct 31, 2018

@Gaurav-Punjabi You can create a pull request that targets QA_4_8.
Do not forget to signoff every commit :)
You can join our Slack or Gitter

@Gaurav-Punjabi Gaurav-Punjabi mentioned this issue Nov 1, 2018
6 tasks
@Gaurav-Punjabi
Copy link
Contributor

Hey I have submitted a pull request, check it out #14702

@ibennetch
Copy link
Member

I'm okay with removing this, especially since you can see the default in the dropdown at the top of the screen.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 1, 2018
@williamdes
Copy link
Member

Closed by #14706 as d8a319a

@williamdes williamdes self-assigned this Nov 3, 2018
@williamdes williamdes added this to the 5.0.0 milestone Nov 3, 2018
@williamdes
Copy link
Member

@MauricioFauth @ibennetch Do I need to add a changelog entry ?

@ibennetch
Copy link
Member

It's not painfully obvious whether this needs a mention or not, but I would make an entry. I think "Removed unlabelled default collation from the bottom of the database list" or something should be pretty clear.

ibennetch added a commit that referenced this issue Nov 7, 2018
…n the commit message)

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants