Invalid default value for bit field

[OlafvdSpek]

While trying to reorder columns in a table:

Original:

`top10Show` bit(1) NOT NULL DEFAULT b'1',

pMA:

`top10Show` BIT(1)   NOT NULL DEFAULT b'0010' AFTER `notified`, 

V: master

[williamdes]

@OlafvdSpek Please try to detail steps to reproduce the issues you submit because it is not always easy for a newbie to reproduce and create a fix.
Thanks :)

[OlafvdSpek]

I know, but that costs way more time that I'd rather spend elsewhere.

[williamdes]

Reproduced on master : 5.0.0-dev
Error when moving columns on : 4.8.x
Impossible to edit the bit column on master: Blank page.

Test data

CREATE TABLE `test` (
  `id` int(11) NOT NULL,
  `a` bit(1) NOT NULL DEFAULT b'1'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;

[williamdes]

And bad displayed default value on 4.8.x
'1'

Screenshot

[OlafvdSpek]

Is the default value shown wrong even for int?

[williamdes]

@OlafvdSpek For me, no, because I did not specify any ;)

[OlafvdSpek]

Ah, I misunderstood the "Aucun(e)". :p

[williamdes]

@OlafvdSpek okay ^^
Thank you for reporting issues ;)

[bahl24]

And bad displayed default value on 4.8.x
'1'

Screenshot

@williamdes @OlafvdSpek This might be because htmlspecialchars in php changes ' to &#039 as a way to prevent scripting attacks in website. Let me see the issue in detail and try to provide a fix.

[bahl24]

@williamdes @ibennetch I worked on the issue and found that $bit_default_value passed to the Util.php is b'1' instead of b'1' . Hence, I modified Util.php to satisfy our needs without affecting previous functionality. Kindly take a look at it.

Also, should I open the pull request for the master branch or QA_4_8 branch. Currently I worked off the QA_4_8 branch and it looks good.

[williamdes]

@bahl24 you can open a PR that targets and uses as base QA_4_8
Thank you for the research :) !

[bahl24]

@bahl24 you can open a PR that targets and uses as base QA_4_8
Thank you for the research :) !

@williamdes done, kindly take a look at it.