Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table level Operations functions missing #14786

Closed
ibennetch opened this issue Dec 15, 2018 · 4 comments
Closed

Table level Operations functions missing #14786

ibennetch opened this issue Dec 15, 2018 · 4 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Milestone

Comments

@ibennetch
Copy link
Member

From https://lists.phpmyadmin.net/pipermail/developers/2018-December/020868.html

Describe the bug

I am using xampp 7.2.12 on Linux (Ubuntu 18.04). Some sections of phpMyAdmin do not appear in the table operations tab? eg table settings, table copy. There's only a table move section. What is the reason?

https://resmim.net/f/i6fiNF.jpg

error_log:

Fatal error: Uncaught Error: Call to undefined method PhpMyAdmin\StorageEngine::getInnodbPluginVersion() in /opt/lampp/phpmyadmin/libraries/classes/Operations.php:1234 Stack trace: #0 /opt/lampp/phpmyadmin/libraries/classes/Operations.php(1144): PhpMyAdmin\Operations->getPossibleRowFormat() #1 /opt/lampp/phpmyadmin/libraries/classes/Operations.php(932): PhpMyAdmin\Operations->getTableOptionFieldset(Object(PhpMyAdmin\Table), '', 'utf8_general_ci', 'INNODB', 'DEFAULT', '0', '2', '1', '', '0') #2 /opt/lampp/phpmyadmin/tbl_operations.php(376): PhpMyAdmin\Operations->getTableOptionDiv(Object(PhpMyAdmin\Table), '', 'utf8_general_ci', 'INNODB', 'DEFAULT', '2', '0', '1', '', '0') #3 {main} thrown in /opt/lampp/phpmyadmin/libraries/classes/Operations.php on line 1234

https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/classes/StorageEngine.php
Line 195: strtolower function does not work like

Xampp 64 bit debian linux version 7.2.12, 7.2.13, 7.3.0 I have tested.

<?php
echo strtolower('Innodb');

// Output
Innodb

Change: mb_strtolower()

@ibennetch
Copy link
Member Author

I can't reproduce this on my local development with the released version of 4.8.4 and PHP 7.2.12, but maybe it's because of some internationalized MySQL or something. The proposed solution seems fine to me, although I'd like to understand more about what causes this.

@williamdes
Copy link
Member

williamdes commented Dec 18, 2018

@ibennetch
https://stackoverflow.com/questions/45515295/turkish-character-bug-in-mb-strtoupper-function-of-php
https://github.com/roundcube/roundcubemail/issues/1872

Setup

apt-get update
apt-get install locales
dpkg-reconfigure locales

Select tr_TR.UTF-8

Code

<?php
<?php
setlocale(LC_ALL, 'tr_TR.UTF-8');
echo strtolower('Innodb') . PHP_EOL;
echo strtoupper('Innodb') . PHP_EOL;

Output

Innodb
INNODB

@williamdes
Copy link
Member

Add to common.inc.php setlocale(LC_ALL, 'tr_TR.UTF8'); to reproduce.
WITH tr_TR.UTF8 locale installed !

@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 18, 2018
@williamdes williamdes added this to the 4.8.4.1 milestone Dec 18, 2018
@williamdes
Copy link
Member

image

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Dec 19, 2018
@williamdes williamdes self-assigned this Dec 19, 2018
williamdes added a commit that referenced this issue Dec 19, 2018
Signed-off-by: William Desportes <williamdes@wdes.fr>
@ibennetch ibennetch modified the milestones: 4.8.4.1, 4.8.5 Dec 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
None yet
Development

No branches or pull requests

2 participants