Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export Database page: UI prevents exporting procedures only #14796

Closed
barrystaes opened this issue Dec 19, 2018 · 1 comment
Closed

Export Database page: UI prevents exporting procedures only #14796

barrystaes opened this issue Dec 19, 2018 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
Milestone
5.1.2

Comments

@barrystaes
Copy link

Describe the bug

On the Export Database page. I found that in PMA 4.8.4 its not possible to export all procedures without exporting some table structure. This worked fine upto 4.7.0 and some newer releases.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Export Database page
  2. Uncheck all tables and structure.
  3. Scroll down to option "add CREATE PROCEDURE / FUNCTION / EVENT statements"
  4. See that these are missing now because all structure was unchecked.

Same story for other options that can pertain to procedures, such as "add DROP".

Expected behavior

Being able to export all procedures. The "smart" UI is preventing this.

A workaround would be the export procedures button in the procedures list page. But this does not output to a file. (and does not sort the procedures by name - making it unfit for version control use, as mentioned in issue #14795)

Additional context

I think this commit introduced this problem: 298ef43
barrystaes referenced this issue Dec 19, 2018
@meteorlxy
fix: toggle export options when selecting all struture or all data in…
298ef43 
… database-level exports

Signed-off-by: Xinyu Liu <meteor.lxy@foxmail.com>
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Dec 19, 2018
@williamdes williamdes added this to To be sorted in issues May 2, 2019
@williamdes williamdes moved this from To be sorted to Reproduced in issues May 3, 2019
@williamdes williamdes added this to the 5.1.1 milestone Mar 14, 2021
@williamdes williamdes modified the milestones: 5.1.1, 5.1.2 Apr 22, 2021
@williamdes
Copy link
Member

Hi @iifawzi
This one is an "easy" one, would you like to have a look ?

@iifawzi iifawzi mentioned this issue Jul 28, 2021
Merged
@williamdes williamdes self-assigned this Aug 8, 2021
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Aug 8, 2021
williamdes added a commit that referenced this issue Aug 9, 2021
@williamdes
Add a ChangeLog entry for #14796
ce3176f 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Reproduced to Closed Aug 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Milestone
5.1.2
Development

No branches or pull requests
2 participants
@barrystaes @williamdes