Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide buttons for tables is too obscure and close to the actual tables #14820

Closed
madmenyo opened this issue Dec 26, 2018 · 14 comments · Fixed by #15871
Closed

Hide buttons for tables is too obscure and close to the actual tables #14820

madmenyo opened this issue Dec 26, 2018 · 14 comments · Fixed by #15871
Assignees
Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Milestone

Comments

@madmenyo
Copy link

Is your feature request related to a problem? Please describe.

I just spend an hour trying to solve why my Laravel project was working correctly without a specific table in the database that should have been migrated properly. I felt like an idiot when I discovered it was hidden but then I noticed extremely obscure eyes next to the tables, only slightly visible when hovering over a table in the left navbar. When a folder is hidden the only way to notice, without knowing you hidden something, is a somewhat less obscure eye next to the database name. But for someone that doesn't know his table is hidden it's not the first place to look.

Describe the solution you'd like

Remove hide button and put it somewhere else.

Describe alternatives you've considered

Put it all the way to the right on the navbar or don't hide it completely when not hovering over a table. Since atm you can easily click it and the only way you know is that you are not redirected to the table you thought you clicked.

Additional context

  • phpMyAdmin version: 4.84

Add any other context or screenshots about the feature request here.

@madmenyo madmenyo changed the title Hide buttons for tables is to obscure and close to the actual tables Hide buttons for tables is too obscure and close to the actual tables Dec 26, 2018
@supra08
Copy link

supra08 commented Dec 27, 2018

@williamdes , can I take up this issue?

@williamdes
Copy link
Member

@supra08 Yes :)

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Dec 27, 2018
@akkywadhwa
Copy link
Contributor

@supra08 Are you still working on this issue?

@akkywadhwa
Copy link
Contributor

@williamdes I suppose @supra08 is not working on this issue now. Can I start working on this issue?

@williamdes
Copy link
Member

@akkywadhwa Yes, no PR is open so you can start working on this issue :)

@akkywadhwa
Copy link
Contributor

akkywadhwa commented Jan 21, 2019

@williamdes Will this work?
pr-2
Should I update it for all the three default themes provided for PhpMyAdmin?

@williamdes
Copy link
Member

@akkywadhwa Looks good !
I think that no eye should be on Views and Tables

Should I update it for all the three default themes provided for PhpMyAdmin?

You can create a PR ;)

@akkywadhwa
Copy link
Contributor

@williamdes According to the present functionality eye on Views and Tables is to hide the whole group. Do you think I should remove these?

@williamdes
Copy link
Member

Do you think I should remove these?

@akkywadhwa No, I did not know, sorry

@akkywadhwa
Copy link
Contributor

@williamdes I achieved the output shown above by changing the code present in "{Location of phpmyadmin}\phpmyadmin\themes\pmahomme\css\theme.css" but in this css folder there's a ".gitignore" file which disallows git to work on ".css" files. What should be the authentic way to deal with this issue?

@akkywadhwa
Copy link
Contributor

@williamdes I achieved the output shown above by changing the code present in "{Location of phpmyadmin}\phpmyadmin\themes\pmahomme\css\theme.css" but in this css folder there's a ".gitignore" file which disallows git to work on ".css" files. What should be the authentic way to deal with this issue?

@williamdes Can you please see this. I am waiting for your reply.

@williamdes
Copy link
Member

williamdes commented Jan 29, 2019

@akkywadhwa You can modify .scss files that are in each theme directory
And run npm run css-compile or yarn run css-compile

@williamdes williamdes added this to Triage zone in Enhancements Jan 23, 2020
@williamdes williamdes moved this from Triage zone to Interface in Enhancements Jan 24, 2020
@rabeehrz
Copy link
Contributor

@williamdes Hey, can I work on this?

@williamdes
Copy link
Member

Hey @rabeehrz
Yes you can

williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Jan 28, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
Enhancements automation moved this from Interface to Done Jan 28, 2020
@williamdes williamdes self-assigned this Jan 28, 2020
@williamdes williamdes added this to the 5.1.0 milestone Jan 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
Enhancements
  
Done
5 participants