Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment field - textarea #14829

Closed
tiomanisland opened this issue Jan 3, 2019 · 10 comments · Fixed by #14881
Closed

Comment field - textarea #14829

tiomanisland opened this issue Jan 3, 2019 · 10 comments · Fixed by #14881
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@tiomanisland
Copy link

Can you please make comment field in phpMyAdmin to be <textarea> instead of field. It is extremely hard to write anything into comment field with so little space. We put whole sentences or short explanation into that field and few characters is simply not enough to see.

When people suggest something, do you have a list of upcoming changes so we can know if someone has read requests? Thank you!

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Jan 3, 2019
@williamdes
Copy link
Member

@tiomanisland Maybe you are looking for: enhancement A feature request for improving phpMyAdmin

@tiomanisland
Copy link
Author

Your link sends me to list of topics. I don't know what you tried to say.

@akkywadhwa
Copy link
Contributor

akkywadhwa commented Jan 19, 2019

@williamdes Can you please tell me about which text area @tiomanisland is talking about? I would like to work on this.

Is @tiomanisland talking about this?
comment

The maximum length for this field is 60. Do I need to increase the maximum length or the size of the visible text of this field should be 60?

@akkywadhwa
Copy link
Contributor

akkywadhwa commented Jan 19, 2019

@williamdes waiting for your answer.

@williamdes
Copy link
Member

@akkywadhwa I think @tiomanisland is talking about the table and column comment fields
Maybe MySQL and MariaDB have restrictions on the length of the comments
Using a textarea could be a good idea :)

@tiomanisland
Copy link
Author

Hello guys, glad to see someone is here. I am talking about comment field next to each column (not the table comment you marked on that pic) but this one - https://prnt.sc/m99j0o - it is very hard to enter anything longer than 10 characters because you have to scroll left and right, not to mention weird chrome/windows 10 behaviour with input boxes. if someone can change this to textarea it would be awesome! Just make it <textarea rows=1> - this way it won't be any higher than it is now and we will be able to resize it in browsers. Try to enter a comment which is one sentence long, then edit it and add/remove something, you will see it is a nightmare.

@tiomanisland
Copy link
Author

@akkywadhwa I think @tiomanisland is talking about the table and column comment fields
Maybe MySQL and MariaDB have restrictions on the length of the comments
Using a textarea could be a good idea :)

The limit is not a problem, I can write a lot in there, the problem is small input field...

@tiomanisland
Copy link
Author

download 4

MauricioFauth added a commit that referenced this issue Jan 25, 2019
Fixed: Comment field - textarea #14829
@MauricioFauth MauricioFauth self-assigned this Jan 25, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone Jan 25, 2019
MauricioFauth added a commit that referenced this issue Jan 25, 2019
- Removes whitespace inside textarea in columns_definitions/column_comment

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@akkywadhwa
Copy link
Contributor

@MauricioFauth Thank you so much!

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 25, 2019
@tiomanisland
Copy link
Author

tiomanisland commented Jan 25, 2019

I edited the file with your changed text and it works! Many many thanks for this to make my life easier!!! 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants