Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer won't show ComboBoxes for onUpdate/onDelete-Behaviour when adding a constraint #14832

Closed
R-Klimkeit opened this issue Jan 4, 2019 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Milestone

Comments

@R-Klimkeit
Copy link

Describe the bug

After upgrading to the most recent version, I encoutered the problem, that the designer will not show up the ComboBoxes for the onUpdate/onDelete-Behaviour when adding a constraint anymore.

To Reproduce

Add a constraint in phpMyAdmin's Designer.
Even if both selected fields satisfy the requirement to be PRIMARY and INDEX, the ComboBoxes will get the wrong CSS-Property "display:none"

Expected behavior

ComboBoxes should get CSS-Property display="" if both selected fields fulfill the above mentioned requirement.

Client configuration

Reproduced with IE9 / Chome / FF

Additional context

There is a Datatype-mismatch-Error in "/js/designer/move.js" in line 1206 and 1214:

    j_tabs[db + '.' + T] !== '1'

must be

    j_tabs[db + '.' + T] !== 1

because the variable j_tabs does not hold string-values but integer-values (at least: anymore).
This change made me get rid of this bug.

@williamdes williamdes self-assigned this Jan 7, 2019
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Jan 14, 2019
@kartik1000
Copy link
Contributor

@williamdes , Hey i reproduced the bug on my local server successfully and yes ensured that the bug can be fixed by changing (j_tabs[db + '.' + T] !== '1') to (j_tabs[db + '.' + T] !== 1) as it is holds some integer value as stated above. Shall I make the PR to fix it if you wish?

@williamdes
Copy link
Member

williamdes commented Feb 8, 2019

@kartik1000 Yes please, to QA_4_8 :)

kartik1000 added a commit to kartik1000/phpmyadmin that referenced this issue Feb 8, 2019
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
kartik1000 added a commit to kartik1000/phpmyadmin that referenced this issue Feb 8, 2019
Signed-off-by: Kartik Kathuria <kathuriakartik0@gmail.com>
williamdes added a commit that referenced this issue Mar 6, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to the 4.8.6 milestone Mar 6, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
None yet
Development

No branches or pull requests

3 participants