Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV for MS Excel export windows-1252 #14837

Closed
theking2 opened this issue Jan 10, 2019 · 3 comments
Closed

CSV for MS Excel export windows-1252 #14837

theking2 opened this issue Jan 10, 2019 · 3 comments
Assignees
Labels
enhancement A feature request for improving phpMyAdmin
Milestone

Comments

@theking2
Copy link
Contributor

theking2 commented Jan 10, 2019

Is your feature request related to a problem? Please describe.

Microsft Excel, tested with Office 2016, imports CSV (character seperated values) default as Windows-1252 character format. PhpMyAdmin defaults to text-export in UTF-8. This can cause texts being imported with wrong or missing characters.

Describe the solution you'd like

By selecting format option "CSV for MS Excel" the user indicates the intended use (Microsoft Excel) . The default character set of the file in phpMyAdmin is UTF-8 yielding diacritical and other text imported wrong. As there are options "CSV"and "CSV for MS Excel" it would make sense that when the user selects "CSV for MS Excel" also the default supported character (windows-1252) is selected as well. In that way the file can be exported and opened in Excel without additional fiddling with configuration or settings.

Describe alternatives you've considered

It is possible in the export to select windows-1252 as character set, or it is possible to manually import the file in Excel by setting the source to 65001 UTF-8. Both need an additional step and can be confusing for the end user or causes (unneeded) support questions.

Additional context

  • phpMyAdmin version: tested with 4.7.9/ PHP 5.6.35 / Mariadb 10.2.14
@williamdes williamdes added the enhancement A feature request for improving phpMyAdmin label Jan 10, 2019
@Enurhe
Copy link

Enurhe commented Jan 14, 2019

I do not have access to Microsoft Office, but recall an issue in this regard a while back on another project. The issue was only present on MS Office for Mac, and not Windows. Only mentioning it if it is the case here.

@kartik1000
Copy link
Contributor

@williamdes, Hey I have made this Enhancement :) Shall I make a PR against master?

@williamdes
Copy link
Member

@kartik1000 Yes, please :)

williamdes added a commit that referenced this issue Mar 2, 2019
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Mar 2, 2019
@williamdes williamdes added this to the 5.0.0 milestone Mar 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin
Projects
None yet
Development

No branches or pull requests

4 participants