Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert page should not allow entering things into virtual columns #14853

Closed
miklcct opened this issue Jan 12, 2019 · 1 comment
Closed

Insert page should not allow entering things into virtual columns #14853

miklcct opened this issue Jan 12, 2019 · 1 comment
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone
4.9.0.1

Comments

@miklcct
Copy link
Contributor

miklcct commented Jan 12, 2019 •
edited

The insert page now currently list all columns, including virtual columns, but anything inputted to it are ignored in the generated SQL query.

Therefore, the page is misleading and may cause inconvenience when entering data into the database. Please disable or remove those virtual columns.
@lem9
Copy link
Contributor

lem9 commented Jan 12, 2019

The same when editing such column.

saurass added a commit to saurass/phpmyadmin that referenced this issue Jan 13, 2019
@saurass
Fix - phpmyadmin#14853 - Insert page should not allow entering things…
13a832b 
… into virtual columns

Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
@saurass saurass mentioned this issue Jan 13, 2019
Merged
6 tasks
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Jan 13, 2019
saurass added a commit to saurass/phpmyadmin that referenced this issue Mar 24, 2019
@saurass
Fix - phpmyadmin#14853 - Insert page should not allow entering things…
a424a39 
… into virtual columns

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@williamdes williamdes self-assigned this Mar 26, 2019
@williamdes williamdes added this to the 4.8.6 milestone Mar 26, 2019
williamdes added a commit that referenced this issue Mar 26, 2019
@williamdes
Fix #14853 - Insert page should not allow entering things into virtua…
298ecbd 
…l columns

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 26, 2019
@williamdes
Add ChangeLog entry for #14853
61eef95 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes mentioned this issue May 7, 2019
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Milestone
4.9.0.1
Development

No branches or pull requests
3 participants
@lem9 @miklcct @williamdes