Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display column details in navigation bar #14890

Closed
nunoperalta opened this issue Jan 22, 2019 · 7 comments · Fixed by #14910
Closed

Display column details in navigation bar #14890

nunoperalta opened this issue Jan 22, 2019 · 7 comments · Fixed by #14910
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@nunoperalta
Copy link

It would be very nice to have more information about the columns in the navigation bar, just like SQL Server Management Studio does.

  • Primary Key or Foreign Key
  • Data Type (int, varchar, date, etc...)
  • NULL or NOT NULL

image

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Jan 22, 2019
@saurass
Copy link
Contributor

saurass commented Jan 27, 2019

@williamdes I would like to work on this : )
First I will begin by working on column view in navigation tree

saurass added a commit to saurass/phpmyadmin that referenced this issue Jan 27, 2019
…avigation tree

Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
@williamdes
Copy link
Member

@saurass You can work on this issue of you want ;)

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 27, 2019
@ibennetch
Copy link
Member

I have two thoughts about this to share; first, we have shied away from this in the past because of wanting to avoid cluttering the interface. With larger screen resolutions now, that may not be a huge issue. Secondly, we can’t too closely emulate some other interface because we want to innovate our own interface and not steal someone else’s ideas.

Those concerns aside, this is an interesting idea.

@saurass
Copy link
Contributor

saurass commented Jan 27, 2019

So should we go for this @ibennetch ?

@nunoperalta
Copy link
Author

nunoperalta commented Jan 27, 2019

@ibennetch - I'm not against taking other interface's ideas. If they are good and beneficial, then I don't see a problem. Database Systems themselves keep copying features from others. That only benefits the users.

Also, this could be very well a setting that allows those who want a simple interface to disable this.

I much more prefer this feature than the "Hide Table" button that I had to hide with AdBlock, because there is no setting to disable that "cluttering" (in my opinion) button :)

Thanks very much for considering this.

@nunoperalta
Copy link
Author

@ibennetch Ok to implement this? :) Thanks very much!

MauricioFauth pushed a commit that referenced this issue May 1, 2019
Fixes #14890

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@MauricioFauth MauricioFauth self-assigned this May 1, 2019
@MauricioFauth MauricioFauth added this to the 5.0.0 milestone May 1, 2019
MauricioFauth added a commit that referenced this issue May 1, 2019
Display column details in navigation bar

- Fix coding standard errors

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants