Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA_4_8] Expanded DB, refresh, plus/minus icon #14896

Closed
williamdes opened this issue Jan 23, 2019 · 7 comments
Closed

[QA_4_8] Expanded DB, refresh, plus/minus icon #14896

williamdes opened this issue Jan 23, 2019 · 7 comments
Assignees
@williamdes
Labels
good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Milestone
4.9.0.1

Comments

@williamdes
Copy link
Member

Describe the bug

Expanded database should keep minus icon if extended when refresh is triggered.

To Reproduce

Steps to reproduce the behavior:

  1. Expand database in tree view
  2. Refresh tree view using green refresh button
  3. Minus icon becomes plus

Expected behavior

Minus should stay minus.

Info

Affects only QA_4_8 !
@williamdes williamdes added help wanted newbie ui Issues relating to the user interface good first issue labels Jan 23, 2019
@bahl24
Copy link
Contributor

bahl24 commented Jan 23, 2019

@williamdes Can I work on this?

@williamdes
Copy link
Member Author

@bahl24 Yes :), If you need more details ?

@bahl24
Copy link
Contributor

bahl24 commented Jan 23, 2019

@williamdes I wasn't able to reproduce the issue on my system so headed over to https://demo.phpmyadmin.net/QA_4_8/index.php to test the same. I noted that only databases with icon in front of them such as in screenshot are having the issue and not other databases.
screenshot from 2019-01-23 19-26-25
screenshot from 2019-01-23 19-26-49
Is this the issue you are talking about?

@williamdes
Copy link
Member Author

@bahl24 Exactly, I forgot to try with simple databases 😕
Thank you for the precision !

@saurass saurass mentioned this issue Jan 24, 2019
Merged
6 tasks
@saurass
Copy link
Contributor

saurass commented Jan 24, 2019

I just created a pull request to QA_4_8 branch @williamdes please review that.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 24, 2019
@bahl24
Copy link
Contributor

bahl24 commented Jan 24, 2019

@saurass I was working on this but anyways thanks for your help. Next time just inform when you take up the issue, because someone might be working on it.

@saurass
Copy link
Contributor

saurass commented Jan 24, 2019 •
edited

@bahl24 sorry for the inconvenience caused, I will be really cautious next time.

williamdes added a commit that referenced this issue Mar 1, 2019
@williamdes
Fix: #14896 - Expanded DB, refresh, plus/minus icon
6054f9e 
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Mar 1, 2019
@williamdes
Add ChangeLog entry for #14896
56ad90a 
[ci skip]
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes added this to the 4.8.6 milestone Mar 1, 2019
@williamdes williamdes self-assigned this Mar 1, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
good first issue has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted newbie ui Issues relating to the user interface
Projects
None yet
Milestone
4.9.0.1
Development

No branches or pull requests
3 participants
@williamdes @saurass @bahl24