Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure inTransformationsPluginsTest #14906

Closed
ibennetch opened this issue Jan 26, 2019 · 6 comments
Closed

Test failure inTransformationsPluginsTest #14906

ibennetch opened this issue Jan 26, 2019 · 6 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature
Projects
issues
Milestone
4.9.2

Comments

@ibennetch
Copy link
Member

When running the testsuite locally, I get this error:

PhpMyAdmin\Tests\Plugins\Transformations\TransformationPluginsTest::testTransformation with data set #25 (PhpMyAdmin\Plugins\Transformations\Text_Plain_Longtoipv4 Object (), array(4294967295.0, array('option1', 'option2')), '255.255.255.255')
long2ip() expects parameter 1 to be int, float given

When run on Travis, it does not seem to have the error.

This happens with both QA_4_8 and master.
@MauricioFauth
Copy link
Member

I could not reproduce that. What is the value of your PHP_INT_MAX constant?

@ibennetch
Copy link
Member Author

2147483647

@MauricioFauth
Copy link
Member

MauricioFauth commented Jan 28, 2019 •
edited

So it's a 32 bit system? Or it's a 32 bit build of PHP?

When a value is greater than PHP_INT_MAX, it is converted to float automatically.

@MauricioFauth MauricioFauth added the Bug A problem or regression with an existing feature label Jan 28, 2019
@williamdes williamdes added this to n/a priority in issues Apr 29, 2019
@ibennetch
Copy link
Member Author

It is a 32-bit system, yes.

@williamdes
Copy link
Member

Reproduced using https://hub.docker.com/r/i386/ubuntu/ on my 64 bit system

@williamdes williamdes mentioned this issue Nov 5, 2019
Merged
@williamdes williamdes self-assigned this Nov 5, 2019
@williamdes williamdes added this to the 4.9.2 milestone Nov 5, 2019
@williamdes
Copy link
Member

williamdes commented Nov 5, 2019 •
edited

Fixed by #15556

@williamdes williamdes moved this from n/a priority to ready to merge in issues Nov 5, 2019
williamdes added a commit to williamdes/phpmyadmintest that referenced this issue Nov 5, 2019
@williamdes
Improve test suite to make it 32bit compatible and more flexible
f627206 
Ref: phpmyadmin#14906
- Fixes the case where you have FilterLanguages in the local config file
- Fixes the case where the php zip or php bz2 extension is not installed

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Nov 5, 2019
@williamdes
Add ChangeLog entry for #14906 and f627206
30ccdd5 
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Nov 5, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature
Projects
issues
  
Closed
Milestone
4.9.2
Development

No branches or pull requests
3 participants
@MauricioFauth @ibennetch @williamdes