Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the 1st day of week of the calendar in config.php #14909

Closed
dddns opened this issue Jan 26, 2019 · 9 comments · Fixed by #14925
Closed

Define the 1st day of week of the calendar in config.php #14909

dddns opened this issue Jan 26, 2019 · 9 comments · Fixed by #14925
Assignees
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
Milestone

Comments

@dddns
Copy link

dddns commented Jan 26, 2019

Howdy,

In every update, i have to manually insert in js/functions.js the line below with the "=>".
How would it be considered to insert this option in config.php?

Thanks in advanced,
Jorge

        PMA_addDatepicker($(this), type, {
            showMillisec: showMillisec,
            showMicrosec: showMicrosec,
            timeFormat: timeFormat,
            hourMax: hourMax,
=>                firstDay: 1
        });
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Jan 27, 2019
@saurass
Copy link
Contributor

saurass commented Jan 29, 2019

@dddns @williamdes , could you elaborate, why you require to add this line as you described above, I mean the motive behind it and what effect it causes, I would love to resolve this : )

@dddns
Copy link
Author

dddns commented Jan 29, 2019

@saurass the 1st day of the week for me it's monday, not sunday.
It's very confusion having PMA showing me the calendar with sunday as the 1st option for the week.

@ibennetch
Copy link
Member

ibennetch commented Jan 29, 2019 via email

@saurass
Copy link
Contributor

saurass commented Jan 29, 2019

@ibennetch I am a gsoc aspirant and would love to work on that. :)

@saurass
Copy link
Contributor

saurass commented Jan 29, 2019

@ibennetch please elaborate how to proceed with this.

@dddns
Copy link
Author

dddns commented Jan 29, 2019

Cool, please do!
A configuration options is the best for this.

saurass added a commit to saurass/phpmyadmin that referenced this issue Jan 31, 2019
…tepicker in server settings -> config -> time form

Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
saurass added a commit to saurass/phpmyadmin that referenced this issue Jan 31, 2019
Signed-off-by: saurass <saurabhsrivastava312@gmail.com>
@saurass
Copy link
Contributor

saurass commented Feb 1, 2019

@williamdes @ibennetch @dddns please review if the changes are placed in correct places.
Also please review the code and suggest changes.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Feb 1, 2019
@dddns
Copy link
Author

dddns commented Apr 17, 2019

Howdy,

Was this commited to the PMA source tree?

@saurass
Copy link
Contributor

saurass commented Apr 17, 2019

No, not yet @dddns

williamdes pushed a commit to saurass/phpmyadmin that referenced this issue Jul 4, 2019
…picker in server settings -> config -> time form

Fixes: phpmyadmin#14909

Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
MauricioFauth added a commit that referenced this issue Nov 7, 2019
Issue #14909 - Define the 1st day of week of the calendar in config.php
@MauricioFauth MauricioFauth self-assigned this Nov 7, 2019
@MauricioFauth MauricioFauth added this to the 5.1.0 milestone Nov 7, 2019
MauricioFauth added a commit that referenced this issue Nov 7, 2019
Add a configuration option to define the 1st day of week

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@williamdes williamdes added this to Needs triage in issues via automation Nov 7, 2019
@williamdes williamdes moved this from Needs triage to Closed in issues Nov 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A feature request for improving phpMyAdmin has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants