Creating a view using a query does not pre-fill the query

[williamdes]

Describe the bug

Creating a view using a query does not pre-fill the query

To Reproduce

Steps to reproduce the behavior:

1. Select from a table
2. Click on 'Create a view'

Expected behavior

Pre-fill the query into the modal

Actual behavior

Empty query

Additional bug

Submit empty modal shows waiting forever !

[bahl24]

@williamdes Are you expecting a default query in AS field?

[williamdes]

@bahl24 Yes, the query that I executed or the one automatically executed when browsing the table

[bahl24]

Let me try this issue

[bahl24]

@williamdes Clicking on table->create view and view->new invoke the same script, so I am planning to use the arguments sent as default value for fields such as 'AS' and 'Column names'.
But I am stuck in how to figure out if table->create view is used or view->new, as table->create view should pre fill the values and view->new should leave them empty.

[williamdes]

@bahl24 phpMyAdmin 4.7.7 had the behavior of using the query, so you can use 4.7.7 to see how it behaved :)

But I am stuck in how to figure out if table->create view is used or view->new, as table->create view should pre fill the values and view->new should leave them empty.

Maybe adding a parameter to fill the query and if no parameter is passed, leave empty ?

[bahl24]

@williamdes Although I am yet to behavior of 4.7.7, kindly take a look at the above commit. I will fix the additional bug shortly.

Additional bug

Submit empty modal shows waiting forever !

[bahl24]

@williamdes As we already have Go and [X] button for the form, do we require the extra 'Go' and 'Cancel' button in the form footer?

[williamdes]

@bahl24 Only cancel seems okay

[ibennetch]

The "Edit view" functionality is also affected by this.

Edit view can be found from the Structure tab of a view, below the column list and above the Partition label.

[bahl24]

@ibennetch @williamdes

I get the following screen when I click on edit view.
So, are you referring to autofill the view name, algorithm, definer and sql security fields?

Also, I feel we should remove 'Go' and "close' button from the form footer as another 'Go' and X icon on top of the create view form is already available.

This also might solve the error you reported #14924 (comment)

[ibennetch]

Changing the interface would be a separate issue to merge in to master only. The bug fix should go to QA_4_8, but we try not to change the interface in the QA branches.

[bahl24]

@ibennetch @williamdes Should I work on removing the buttons then? This will fix #14924 (comment)