View overview: add an Edit link for each view

[ibennetch]

Is your feature request related to a problem? Please describe.

The list of views should show an edit link for each view. From the navigation pane, there's a "Views" text which can be clicked on to show all the views in the database. There's a list of tabs, "Browse," "Structure," etc — I propose adding an "Edit" link here.

I don't think we can add "Edit" to the dropdown list for working with multiple views, because it wouldn't make sense to edit more than one at once.

• phpMyAdmin version:

QA_4_8

[bahl24]

@ibennetch Can I take up this issue?
Also, I think we should create a new php file edit_create.php as the current file calls view_create.php?
We can auto fill the form in edit_view.php.

[bahl24]

@ibennetch @williamdes Should I create new view_edit file or try to autofill existing view_create file?

[ibennetch]

I think this can be added to the existing file. Is there a particular reason it would make more sense to create edit_view.php?

[bahl24]

ok @ibennetch , I will modify the existing file itself

[bahl24]

@ibennetch @williamdes How can I set a global variable such as $_POST['alterview']

[bahl24]

@ibennetch @williamdes If we go to structure tab in a view, then click on edit view, what we get is a form to create view and not edit the view. You can test it by trying to modify the view by putting VIEW name as the view which you previously selected and change AS fields.
This will throw the error saying that view already exists.
Thus currently there is no way to edit a view once created either from Structure tab or this enhancement issue.
We might need to create a new file for editing views. What do you think?

[ibennetch]

You’re seeing this bug: bug #14916 (comment)

[bahl24]

@ibennetch So maybe I should make a pr for the bug fix currently to branch QA. And work on the feature request (creating new file for editing views) off the master branch. The pr for #14916 is mine only and I encountered the error you are mentioning.

[williamdes]

Fixed by a7ac037