Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0+] Display NULL on numeric fields #14936

Closed
OlafvdSpek opened this issue Feb 7, 2019 · 13 comments
Closed

[5.0+] Display NULL on numeric fields #14936

OlafvdSpek opened this issue Feb 7, 2019 · 13 comments
Assignees
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
Milestone

Comments

@OlafvdSpek
Copy link

Null values appear to be displayed as empty strings in result tables, could this be changed such that it's displayed the same as when viewing a null default value in the structure page?

@kartik1000
Copy link
Contributor

@OlafvdSpek Can you please elaborate the issue? Will be helpful in exactly knowing what needs to be changed.

@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Feb 7, 2019
@bahl24
Copy link
Contributor

bahl24 commented Feb 7, 2019

@OlafvdSpek As much as I can understand, it is because you can double click the null value on browse page for inline editing. But on the structure page, there is no need of editing.
screenshot from 2019-02-07 19-11-30
Correct me if I am wrong.

@kartik1000
Copy link
Contributor

@williamdes, Hey is this Enhancement required? I too feel it will be better if we display Null instead of empty strings which will make it more clear.

@williamdes
Copy link
Member

williamdes commented Feb 28, 2019

I too feel it will be better if we display Null instead of empty strings which will make it more clear

I agree, maybe a PR can be done if you want :)

@bahl24
Copy link
Contributor

bahl24 commented Feb 28, 2019

@williamdes But then inline editing won't be possible, to edit the NULL value

@marcus-hiles
Copy link

I agree also, displaying null will be better

@shucon
Copy link
Contributor

shucon commented Mar 25, 2019

@williamdes Is this issue fixed?

@williamdes
Copy link
Member

I am not sure, @OlafvdSpek ? (latest QA snapshot)

@OlafvdSpek
Copy link
Author

What commit would've fixed it?

@LagodichYuriy
Copy link

LagodichYuriy commented Dec 27, 2019

"Enhancement" is not the right label for this issue. There's a big difference between NULL and empty string. It's a disgusting bug and old versions of phpMyAdmin had the right NULL displaying mechanism. 5.0.0-rc1 is not fixed at this moment.

@williamdes williamdes removed the enhancement A feature request for improving phpMyAdmin label Dec 27, 2019
@williamdes williamdes added this to Needs triage in issues via automation Dec 27, 2019
@williamdes williamdes self-assigned this Dec 27, 2019
@williamdes
Copy link
Member

@LagodichYuriy Thank you for pointing this out, on the latest 4.9 version (4.9.3) it is okay ?
If yes it is a regression

@LagodichYuriy
Copy link

4.9.3 - bug is fixed (NULL displays as expected), 5.0.0 - bug appeared again.

@williamdes williamdes added the Bug A problem or regression with an existing feature label Dec 27, 2019
@williamdes williamdes added this to the 5.0.1 milestone Dec 27, 2019
@williamdes
Copy link
Member

williamdes commented Dec 30, 2019

Before 3dce65d

image

After 3dce65d

image

@williamdes williamdes changed the title Display NULL [5.0+] Display NULL on numeric fields Dec 30, 2019
williamdes added a commit that referenced this issue Dec 30, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from Needs triage to Closed Dec 30, 2019
williamdes added a commit that referenced this issue Jan 2, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature ui Issues relating to the user interface
Projects
issues
  
Closed
Development

No branches or pull requests

7 participants