Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer page save fails if dB name contains period. #14945

Open
cj1067b opened this issue Feb 9, 2019 · 3 comments

Comments

3 participants
@cj1067b
Copy link

commented Feb 9, 2019

Ver 4.8.5, repeatable
Open database with a period in the name
Ex beta.testdb

When saving page from designer, an error box opens "insert into phpmyadmin.pma__table_coords..."

Viewing the pma_table_coords, phpmyadmin saved the part of the database name before the period, in the case above "beta" into the db_name column, which I believe should be the full database name, and the part after the period, "testdb" as the table name.

@marcus-hiles

This comment has been minimized.

Copy link

commented Feb 28, 2019

Hi @cj1067b, could you please provide some snap to aid in reproducing this, thanks?

@cj1067b

This comment has been minimized.

Copy link
Author

commented Mar 1, 2019

I'm not seeing an option to attach snaps. I'm writing this with Firefox on Android.

create a database "test.db"
Create table 1, with an ID field primary.
Create table 2, with a table1_id column, indexed.

Go to the designer, show both tables and create a relationship between ID in table 1 and table1_id column in table2.
As soon as I created this, the designer blanked. If I show the 2 tables in designer again, it does not show the relationship. If you try to create the relationship again, it says "error: relationship already exists".
Try to save the designer page
Then view the pma__table__coords in the phpmyadmin database.
It will show, just 1 row,
"test" in the "db_name" column
"db" in the "table_name" column.

It should show 2 rows with "test.db" in the db_name column, and table1/table2 in the "table_name" column on separate rows.

Now if you try this again, but in a database called testdb, no period, it works as it should.

@williamdes

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

Reproduced some of the issue on demo server (root, no password)

@williamdes williamdes added the bug label Mar 1, 2019

@williamdes williamdes added this to to be fixed soon in pull-requests and issues Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.