Faster index rename

[linaspasv]

phpMyAdmin is still using the old DROP INDEX and ADD INDEX method when someone tries to rename index/key. It's not the problem for small tables but it's time consuming for a larger ones.

As of MySQL 5.7 version RENAME INDEX is possible through ALTER TABLE (please see http://dev.mysql.com/doc/refman/5.7/en/alter-table.html). It would be nice if we could have a possibility of RENAME INDEX if nothing else except name has changed during index/key edit.

Thanks.

[shucon]

@ibennetch @williamdes what do you think? I think it would be a good enhancement.

[williamdes]

@shucon I think adding the new syntax could be great is we detect that the version supports it :)

[kartik1000]

@williamdes, Hey don't you think we already have this feature. See this

This is in the insert section, from the edit we can easily edit the name.
Do let me know your views on it.

[ibennetch]

@kartik1000 maybe I’m misunderstanding something, but think that interface uses the DROP INDEX / ADD INDEX syntax referenced in the original post. The feature request is about changing the back end to use RENAME INDEX where supported.

[williamdes]

@williamdes, Hey don't you think we already have this feature.

@kartik1000 as @ibennetch explained, this is more about the SQL syntax to use for renaming an index :)

[kartik1000]

Yup @ibennetch and @williamdes, got it from the first line I thought it was about front-end. That's why the issue seemed a bit weird to me. Thanks for the Explaination :)

[williamdes]

@kartik1000 do you want to implement the change ?

[kartik1000]

@williamdes Yes surely.

[kartik1000]

@williamdes Shall I add another button of 'rename' in addition to edit and drop or should it work through edit only?

[williamdes]

If RENAME support changing the definition of the index then use edit.
If RENAME only does renaming add a rename button.

[kartik1000]

I will add a button then because it only renames the button. I referred to the documentation given in description of the issue

[kartik1000]

@williamdes Does something like this look good?

[williamdes]

@kartik1000 Yeah, looks good !

[kartik1000]

@williamdes I have implemented this feature but this is not supported by MariaDB and is supported by only MySQL after MySQL 5.7. I should have checked this first 😅 . What should I do now?

[williamdes]

@kartik1000 I think you need to hide the button or disable it
Maybe disabling the button and adding a tooltip to explain could be an idea

[kartik1000]

@williamdes I thought we can keep the button for MariaDB but it will perform task through add/drop instead of rename. What do you think?

[williamdes]

Yeah, very good idea!