Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtuality is not selected when editing generated column #14957

Closed
linaspasv opened this issue Feb 15, 2019 · 8 comments
Closed

Virtuality is not selected when editing generated column #14957

linaspasv opened this issue Feb 15, 2019 · 8 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@linaspasv
Copy link

When trying to edit a generated column, a correct virtuality option is not being picked from a dropdown. I have not tested other version but latest 5.0.0-dev is affected.

@bahl24
Copy link
Contributor

bahl24 commented Feb 15, 2019

@linaspasv Can you elaborate testing instructions or provide screenshots?

@linaspasv
Copy link
Author

So I got a generated column on table and when I try on change it, the dropdown for virtuality is empty in edit page (it should have been selected as persistant in my case). Also, I have tested on the latest stable release and the same problem is there aswell.

image

I hope it helps, let me know if you need more details.

@bahl24
Copy link
Contributor

bahl24 commented Feb 17, 2019

@linaspasv I was able to reproduce the issue and found that virtuality is missing but expression is prefilled.

@linaspasv
Copy link
Author

@bahl24 correct, the expression is here but virtuality option is not being selected from the dropdown. But when virtuality is not being pre-selected and you click on save, phpmyadmin alters column to a regular one. In my case, this led to accidental overwrite of a generated column.

@bahl24
Copy link
Contributor

bahl24 commented Feb 20, 2019

@linaspasv Which database server are you using, MySQL or MariaDB?

@linaspasv
Copy link
Author

@bahl24 I am using MariaDB 10.3 . I have not tested with MySQL.

@bahl24
Copy link
Contributor

bahl24 commented Feb 20, 2019

@linaspasv Kindly check

@linaspasv
Copy link
Author

@bahl24 I have tested the change and it works perfectly. Very good job, thanks!

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Feb 23, 2019
williamdes added a commit that referenced this issue Mar 26, 2019
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Mar 26, 2019
@williamdes williamdes added this to the 4.8.6 milestone Mar 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

No branches or pull requests

3 participants