Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird error for collation = '' #14987

Closed
OlafvdSpek opened this issue Mar 1, 2019 · 6 comments
Closed

Weird error for collation = '' #14987

OlafvdSpek opened this issue Mar 1, 2019 · 6 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
Milestone
4.9.1

Comments

@OlafvdSpek
Copy link

https://demo.phpmyadmin.net/master-config/db_operations.php?db=Books

Select blank collation, click Go.

pma
@williamdes williamdes added the Bug A problem or regression with an existing feature label Mar 1, 2019
@kartik1000
Copy link
Contributor

@williamdes, Can you explain the expected behaviour like. if it should set some default collation, or it should simply give error? :)

@williamdes
Copy link
Member

@kartik1000 Select the empty option in the collation list and execute "change all tables collations"

@sijie123
Copy link
Contributor

sijie123 commented Mar 16, 2019 •
edited

This issue happens because users are not required to select any particular value within the dropdown list. When PMA sees that nothing has been selected, i.e. $_POST['db_collation'] is not set when the form is POSTed, then it's as good as if a user has just navigated to the page. Hence the response is a new form as shown in the screenshot by @OlafvdSpek.

I will work on a fix for this issue. I propose to add a check for the select field. This way, the user will be presented with an error message if they ever selected the blank option.

@sijie123 sijie123 mentioned this issue Mar 16, 2019
Merged
6 tasks
@kartik1000
Copy link
Contributor

LGTM 👍.Hey @sijie123 I would suggest you to wait for @williamdes 's opinion about this one

@williamdes
Copy link
Member

I will work on a fix for this issue. I propose to add a check for the select field. This way, the user will be presented with an error message if they ever selected the blank option.

I agree!

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 1, 2019
@williamdes williamdes added this to ready to merge in issues Apr 29, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 28, 2019
@williamdes williamdes self-assigned this May 28, 2019
@williamdes williamdes removed this from the 4.8.6 milestone May 28, 2019
williamdes added a commit that referenced this issue Jun 22, 2019
@williamdes
Fix #14987 - Weird error for empty collation
562ce3a 
Fixes: #14987
Pull-request: #15031

Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from ready to merge to Closed Jun 22, 2019
@williamdes williamdes added this to the 4.9.1 milestone Jun 22, 2019
williamdes added a commit that referenced this issue Jun 22, 2019
@williamdes
Add ChangeLog entries for #14270 #14363 and #14987
b6a354a 
[ci skip]

Signed-off-by: William Desportes <williamdes@wdes.fr>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete
Projects
issues
  
Closed
Milestone
4.9.1
Development

No branches or pull requests
4 participants
@sijie123 @OlafvdSpek @williamdes @kartik1000