Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Cookie Validity #15001

Closed
jonjie0317 opened this issue Mar 6, 2019 · 22 comments · Fixed by #15145
Closed

Login Cookie Validity #15001

jonjie0317 opened this issue Mar 6, 2019 · 22 comments · Fixed by #15145
Assignees
Labels
Bug A problem or regression with an existing feature enhancement A feature request for improving phpMyAdmin
Projects
Milestone

Comments

@jonjie0317
Copy link

jonjie0317 commented Mar 6, 2019

This might be a useful feature until I upgrade my wamp to 3.1.7 which has phpmyadmin v4.8.4. How can I set this now?

Screenshot:

@ibennetch ibennetch added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Mar 6, 2019
@ibennetch
Copy link
Member

Are you saying that you had been able to set LoginCookieValidity through the "Settings" tab? If so, please let me know which version you had so we can look in to why this disappeared.

Aside from that, not all of the configuration options are exposed in the Settings tab, for some (including, I thought, LoginCookieValidity), you have to edit the configuration file config.inc.php and add a line like $cfg['LoginCookieValidity'] = 3600;.

@jonjie0317
Copy link
Author

jonjie0317 commented Mar 6, 2019

@ibennetch

@ibennetch
Copy link
Member

Ok, thanks. Could you tell me which version that is? Version information is on the main page, in the right hand column.

@jonjie0317
Copy link
Author

jonjie0317 commented Mar 7, 2019

Ok, thanks. Could you tell me which version that is? Version information is on the main page, in the right hand column.

@ibennetch It was v4.6.4.

@jonjie0317
Copy link
Author

@ibennetch Any updates?

@ibennetch
Copy link
Member

Thanks for providing the additional information. I was able to determine that this was removed with commit 1fb2887 for the release of 4.8.0.

I'm not certain, but I think the intention with that commit was to maintain consistency; I think there's no reason we can't incorporate some more of the cookie settings here.

@williamdes williamdes added Bug A problem or regression with an existing feature and removed question Used when we need feedback from the submitter or when the issue is a question about PMA labels Mar 14, 2019
@saurass
Copy link
Contributor

saurass commented Mar 30, 2019

@ibennetch should I work on this and incorporate the cookie setting?

@williamdes
Copy link
Member

@saurass You can work on this one if you want and we will review your PR :)

@saurass
Copy link
Contributor

saurass commented Mar 31, 2019

Okay great !

saurass added a commit to saurass/phpmyadmin that referenced this issue Apr 2, 2019
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Apr 4, 2019
@williamdes
Copy link
Member

@ibennetch should the #15145 PR target QA_4_8 ?

@williamdes
Copy link
Member

@ibennetch ?

@williamdes williamdes added this to Medium priority in issues May 1, 2019
@williamdes williamdes added this to the 4.8.6 milestone May 18, 2019
@williamdes williamdes self-assigned this May 18, 2019
williamdes pushed a commit to saurass/phpmyadmin that referenced this issue May 18, 2019
Signed-off-by: Saurabh Srivastava <saurabhsrivastava312@gmail.com>
@williamdes williamdes modified the milestones: 4.9.0.1, 4.9.1 Jun 4, 2019
@williamdes williamdes removed this from the 4.9.1 milestone Jun 17, 2019
@williamdes williamdes removed their assignment Jun 17, 2019
@williamdes williamdes added undecided and removed has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Jan 28, 2020
@williamdes williamdes moved this from Medium priority to n/a priority in issues Jan 28, 2020
@jdtechsol
Copy link

So... the ability to modify this value via the web interface was removed in 4.9.0.1?

@williamdes
Copy link
Member

So... the ability to modify this value via the web interface was removed in 4.9.0.1?

I would say 4.8.0 #15001 (comment)

@alexissel
Copy link

I'm using v5.0.1 and I cannot see the "Login Cookie Validity" option in Settings -> Features.

Do you have any suggestions?

@williamdes
Copy link
Member

For now you can use the config file, I am not sure why it was removed

@str
Copy link

str commented Nov 3, 2020

I got here because the my phpAdmin 5.0.2 did not had the option to change session duration in the frontend. I looked in the config.inc.sample.php file and it was no there neither.

@williamdes
Copy link
Member

I got here because the my phpAdmin 5.0.2 did not had the option to change session duration in the frontend. I looked in the config.inc.sample.php file and it was no there neither.

Hi @str
Are you looking for https://docs.phpmyadmin.net/en/latest/config.html#cfg_LoginCookieValidity ?

@str
Copy link

str commented Nov 3, 2020

@williamdes Yes I was looking for anything related to Login OR Cookies, but didn't found it in the "sample.inc" file. Usually those sample files have all config flags set with default values, for one to change, but in this case, there was none.

image
image

@williamdes
Copy link
Member

Yes, because we have a lot of them and want to have a small sample file :)
You can find all configs in https://github.com/phpmyadmin/phpmyadmin/blob/RELEASE_5_0_4/libraries/config.default.php but do not edit this file.

@str
Copy link

str commented Nov 3, 2020

I don't know Rick... removing the flag from the GUI as well as the config file, makes it look like a deprecated flag. I understand you, but most users won't go through the process of digging into github's issues to find out which one is the deprecated one, if the documentation, the flag, or the config demo file.

@williamdes
Copy link
Member

Maybe @ibennetch could give a final point of view to close this issue ?
It is quite an old one and I do not know more about if it should show on the GUI or not

@ibennetch
Copy link
Member

I'm fine with us merging #15145 and adding this setting back to the GUI.

williamdes added a commit that referenced this issue Nov 4, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Nov 4, 2020
Signed-off-by: William Desportes <williamdes@wdes.fr>
issues automation moved this from n/a priority to Closed Nov 4, 2020
@williamdes williamdes self-assigned this Nov 4, 2020
@williamdes williamdes added this to the 5.1.0 milestone Nov 4, 2020
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin and removed undecided labels Nov 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature enhancement A feature request for improving phpMyAdmin
Projects
issues
  
Closed
Development

Successfully merging a pull request may close this issue.

7 participants