Sql preview empty modal on tbl_relation

[williamdes]

Use following links
Demo servers (root, no password)

• 5.0.0-dev
• 4.8.x

tbl_relation.php?db=information_schema&table=INNODB_BUFFER_PAGE

Bug

• Click on SQL PREVIEW button
• Shows empty modal (this is the issue, why is it empty..)

[williamdes]

@MauricioFauth Can you please have a look why tbl_relation has a 500 on demo server ?

[kartik1000]

@williamdes, Hey the above link is not working for me. Can you please check?

[williamdes]

@kartik1000 Hello, see my comment above and use 4.x server please :)

[apoorvkhare07]

@williamdes I am on it, if no one else is working on this ?

[williamdes]

@apoorvkhare07 Great, go ahead !

[apoorvkhare07]

@williamdes Is the demo server 4.8.x continuously in sync with branch QA_4_8 or its a release of some checkpoint of QA_4_8 ?

[williamdes]

@apoorvkhare07 The demo server 4.8.x is in sync with commits on QA_4_8 :)
So you can open PRs against QA_4_8 since it is the branch for next release

[apoorvkhare07]

@williamdes If server 4.8.x is continuously in sync with the QA_4_8 branch. Why is there some difference in the server and my local phpmyadmin version.

eg: Relational view button is not coming for all databases and only for those there is empty modal on Preview sql.

This is on the 4.8 server :

And this is on mylocal (directly using the URL as there is no button):

Is this issue because of my local database (permission or something else) ?

[williamdes]

@apoorvkhare07 I do not know there is some reason but, for this issue it it quite typical to have those differences..
Mostly because of infrastructure configurations IMHO

Does this answer your question ?

[apoorvkhare07]

@williamdes Not really. But I seem to have found the solution to this. It is giving empty modal because the previewSQL is being called from here
if (isset($_POST['destination_foreign_db'])) { $this->updateForForeignKeysAction(); }
and in some cases destination_foreign_db param is not set in the request so the modal is coming empty.

I think instead of sending empty destination_foreign_db param in request, we can safely remove the isset check and add checks at other places required. This will safely fix the issue.